diff mbox series

[net-next,v2,09/10] can: ems_pci: Remove unnecessary (void*) conversions

Message ID 20230710064138.173912-1-suhui@nfschina.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series Remove unnecessary (void*) conversions | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1341 this patch: 1341
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang success Errors and warnings before: 1364 this patch: 1364
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1364 this patch: 1364
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 24 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Su Hui July 10, 2023, 6:41 a.m. UTC 
From: wuych <yunchuan@nfschina.com>

Pointer variables of void * type do not require type cast.

Signed-off-by: wuych <yunchuan@nfschina.com>
---
 drivers/net/can/sja1000/ems_pci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Marc Kleine-Budde July 10, 2023, 6:49 a.m. UTC | #1 
On 10.07.2023 14:41:38, Su Hui wrote:
> From: wuych <yunchuan@nfschina.com>
> 
> Pointer variables of void * type do not require type cast.

I like the idea. Please add my Acked-by: Marc Kleine-Budde
<mkl@pengutronix.de>, after you've fixed the issue:

> Signed-off-by: wuych <yunchuan@nfschina.com>

This patch is not Signed-off-by the contributing person.

regards,
Marc
Wu Yunchuan July 10, 2023, 6:53 a.m. UTC | #2 
On 2023/7/10 14:49, Marc Kleine-Budde wrote:
> On 10.07.2023 14:41:38, Su Hui wrote:
>> From: wuych <yunchuan@nfschina.com>
>>
>> Pointer variables of void * type do not require type cast.
> I like the idea. Please add my Acked-by: Marc Kleine-Budde
> <mkl@pengutronix.de>, after you've fixed the issue:
that's great, I will do this.
thanks:)!

wuych

>> Signed-off-by: wuych <yunchuan@nfschina.com>
> This patch is not Signed-off-by the contributing person.
>
> regards,
> Marc
>
Wu Yunchuan July 10, 2023, 7:03 a.m. UTC | #3 
On 2023/7/10 14:53, yunchuan wrote:
> On 2023/7/10 14:49, Marc Kleine-Budde wrote:
>> On 10.07.2023 14:41:38, Su Hui wrote:
>>> From: wuych <yunchuan@nfschina.com>
>>>
>>> Pointer variables of void * type do not require type cast.
>> I like the idea. Please add my Acked-by: Marc Kleine-Budde
>> <mkl@pengutronix.de>, after you've fixed the issue:
> that's great, I will do this.
> thanks:)!
>
> wuych
>
>>> Signed-off-by: wuych <yunchuan@nfschina.com>
>> This patch is not Signed-off-by the contributing person.
>>

Oh, sorry for this, I just mixed the email because of some careless reasons.
The send email <suhui@nfschina.com> is my co-worker.
But the contributing person is me, sorry again!

wuych


>> regards,
>> Marc
>>
diff mbox series

Patch

diff --git a/drivers/net/can/sja1000/ems_pci.c b/drivers/net/can/sja1000/ems_pci.c
index c56e27223e5f..ac86640998a8 100644
--- a/drivers/net/can/sja1000/ems_pci.c
+++ b/drivers/net/can/sja1000/ems_pci.c
@@ -148,7 +148,7 @@  static void ems_pci_v1_write_reg(const struct sja1000_priv *priv,
 
 static void ems_pci_v1_post_irq(const struct sja1000_priv *priv)
 {
-	struct ems_pci_card *card = (struct ems_pci_card *)priv->priv;
+	struct ems_pci_card *card = priv->priv;
 
 	/* reset int flag of pita */
 	writel(PITA2_ICR_INT0_EN | PITA2_ICR_INT0,
@@ -168,7 +168,7 @@  static void ems_pci_v2_write_reg(const struct sja1000_priv *priv,
 
 static void ems_pci_v2_post_irq(const struct sja1000_priv *priv)
 {
-	struct ems_pci_card *card = (struct ems_pci_card *)priv->priv;
+	struct ems_pci_card *card = priv->priv;
 
 	writel(PLX_ICSR_ENA_CLR, card->conf_addr + PLX_ICSR);
 }
@@ -186,7 +186,7 @@  static void ems_pci_v3_write_reg(const struct sja1000_priv *priv,
 
 static void ems_pci_v3_post_irq(const struct sja1000_priv *priv)
 {
-	struct ems_pci_card *card = (struct ems_pci_card *)priv->priv;
+	struct ems_pci_card *card = priv->priv;
 
 	writel(ASIX_LINTSR_INT0AC, card->conf_addr + ASIX_LINTSR);
 }