From patchwork Mon Jul 10 07:19:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13306353 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF5D0BA35 for ; Mon, 10 Jul 2023 07:20:01 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22FCE9D for ; Mon, 10 Jul 2023 00:20:00 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIlBX-0008Dq-Tz; Mon, 10 Jul 2023 09:19:51 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qIlBV-00DMeD-Hc; Mon, 10 Jul 2023 09:19:49 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qIlBU-003jlx-S6; Mon, 10 Jul 2023 09:19:48 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Madalin Bucur , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maciej Fijalkowski Cc: Russell King , netdev@vger.kernel.org, kernel@pengutronix.de, Madalin Bucur , Michal Kubiak Subject: [PATCH net-next v3 1/8] net: dpaa: Improve error reporting Date: Mon, 10 Jul 2023 09:19:39 +0200 Message-Id: <20230710071946.3470249-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230710071946.3470249-1-u.kleine-koenig@pengutronix.de> References: <20230710071946.3470249-1-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1586; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=V82Fftf1dNw9TItUTZGo3u1Fg/22XIndyV4jQZLYzg8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkq7EG1XS3XKSBe649yDexes/0YjymEihTUHKL+ qui7T7dageJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZKuxBgAKCRCPgPtYfRL+ Th+mB/9s8WZValBNtqWAXCwJ0Uv08Kl4EROQqQVk/oeZmi9X1FPXb5xn3O3gpn3JnskFEQ65o1m 0P1JYq58JXhmV+EOgdcueTXFNpc6AiYkRxE84w9jKU8hdchJDU2a5L29oxIM7uQ6lHZUbNqwd07 r7GQqerhM+EjkGJOqCvgHwxKaYPvYIt/3LNEPdzvE41328HWY1TnPEAEItdhPPrB+iGg5xumQu/ Yyqkz5ncOWvj06jatlkGJMest3fDqpuTvp2EC9JyNl5GvvVKjaZz4eKQjt/jRuawgorhMrYgQ9x B+0vHKB+UMU0Pe5FYHxsP9kUI7IUb2BBHisH8N9sEjDbBJZw X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Instead of the generic error message emitted by the driver core when a remove callback returns an error code ("remove callback returned a non-zero value. This will be ignored."), emit a message describing the actual problem and return zero to suppress the generic message. Note that apart from suppressing the generic error message there are no side effects by changing the return value to zero. This prepares changing the remove callback to return void. Acked-by: Madalin Bucur Reviewed-by: Michal Kubiak Signed-off-by: Uwe Kleine-König --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 431f8917dc39..e0e5bf0587fc 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -3516,6 +3516,9 @@ static int dpaa_remove(struct platform_device *pdev) phylink_destroy(priv->mac_dev->phylink); err = dpaa_fq_free(dev, &priv->dpaa_fq_list); + if (err) + dev_err(dev, "Failed to free FQs on remove (%pE)\n", + ERR_PTR(err)); qman_delete_cgr_safe(&priv->ingress_cgr); qman_release_cgrid(priv->ingress_cgr.cgrid); @@ -3528,7 +3531,7 @@ static int dpaa_remove(struct platform_device *pdev) free_netdev(net_dev); - return err; + return 0; } static const struct platform_device_id dpaa_devtype[] = {