| Message ID | 20230713121633.8190-1-machel@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a822551c51f0dc063305ca16b9dd0dec7fe1f259 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v1] net: ethernet: Remove repeating expression | expand |
On Thursday, July 13, 2023 8:16 PM, Wang Ming wrote: > Identify issues that arise by using the tests/doublebitand.cocci > semantic patch. Need to remove duplicate expression in if statement. > > Signed-off-by: Wang Ming <machel@vivo.com> > --- > drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c > index 39a9aeee7aab..6321178fc814 100644 > --- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c > +++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c > @@ -1511,7 +1511,6 @@ static void wx_configure_rx(struct wx *wx) > psrtype = WX_RDB_PL_CFG_L4HDR | > WX_RDB_PL_CFG_L3HDR | > WX_RDB_PL_CFG_L2HDR | > - WX_RDB_PL_CFG_TUN_TUNHDR | > WX_RDB_PL_CFG_TUN_TUNHDR; > wr32(wx, WX_RDB_PL_CFG(0), psrtype); Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 13 Jul 2023 20:16:03 +0800 you wrote: > Identify issues that arise by using the tests/doublebitand.cocci > semantic patch. Need to remove duplicate expression in if statement. > > Signed-off-by: Wang Ming <machel@vivo.com> > --- > drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [net,v1] net: ethernet: Remove repeating expression https://git.kernel.org/netdev/net/c/a822551c51f0 You are awesome, thank you!
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c index 39a9aeee7aab..6321178fc814 100644 --- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c +++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c @@ -1511,7 +1511,6 @@ static void wx_configure_rx(struct wx *wx) psrtype = WX_RDB_PL_CFG_L4HDR | WX_RDB_PL_CFG_L3HDR | WX_RDB_PL_CFG_L2HDR | - WX_RDB_PL_CFG_TUN_TUNHDR | WX_RDB_PL_CFG_TUN_TUNHDR; wr32(wx, WX_RDB_PL_CFG(0), psrtype);
Identify issues that arise by using the tests/doublebitand.cocci semantic patch. Need to remove duplicate expression in if statement. Signed-off-by: Wang Ming <machel@vivo.com> --- drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 - 1 file changed, 1 deletion(-)