| Message ID | 20230718090914.282293-1-eugen.hristev@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 51318bf443955b083d12ab7d7a168e18ea6e14da |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hi, On Tue, Jul 18, 2023 at 12:09:14PM +0300, Eugen Hristev wrote: > 'clock_in_out' property is optional, and it can be one of two enums. > The binding does not specify what is the behavior when the property is > missing altogether. > Hence, add a default value that the driver can use. > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 176ea5f90251..bb943c96c196 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -80,6 +80,7 @@ properties: > "output" means GMAC provides the reference clock. > $ref: /schemas/types.yaml#/definitions/string > enum: [input, output] > + default: input > > rockchip,grf: > description: The phandle of the syscon node for the general register file. > -- > 2.34.1 > > > -- > To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.
On Tue, 18 Jul 2023 12:09:14 +0300, Eugen Hristev wrote: > 'clock_in_out' property is optional, and it can be one of two enums. > The binding does not specify what is the behavior when the property is > missing altogether. > Hence, add a default value that the driver can use. > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 18 Jul 2023 12:09:14 +0300 you wrote: > 'clock_in_out' property is optional, and it can be one of two enums. > The binding does not specify what is the behavior when the property is > missing altogether. > Hence, add a default value that the driver can use. > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > > [...] Here is the summary with links: - dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out https://git.kernel.org/netdev/net-next/c/51318bf44395 You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index 176ea5f90251..bb943c96c196 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -80,6 +80,7 @@ properties: "output" means GMAC provides the reference clock. $ref: /schemas/types.yaml#/definitions/string enum: [input, output] + default: input rockchip,grf: description: The phandle of the syscon node for the general register file.
'clock_in_out' property is optional, and it can be one of two enums. The binding does not specify what is the behavior when the property is missing altogether. Hence, add a default value that the driver can use. Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> --- Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 + 1 file changed, 1 insertion(+)