diff mbox series

[v5,1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg

Message ID 20230720111509.21843-2-samin.guo@starfivetech.com (mailing list archive)
State Accepted
Delegated to: Netdev Maintainers
Headers show
Series Add motorcomm phy pad-driver-strength-cfg support | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 9 this patch: 9
netdev/cc_maintainers warning 1 maintainers not CCed: conor+dt@kernel.org
netdev/build_clang success Errors and warnings before: 9 this patch: 9
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 9 this patch: 9
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 40 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Guo Samin July 20, 2023, 11:15 a.m. UTC 
The motorcomm phy (YT8531) supports the ability to adjust the drive
strength of the rx_clk/rx_data.

The YT8531 RGMII LDO voltage supports 1.8V/3.3V, and the
LDO voltage can be configured with hardware pull-up resistors to match
the SOC voltage (usually 1.8V). The software can read the registers
0xA001 obtain the current LDO voltage value.

Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
Signed-off-by: Samin Guo <samin.guo@starfivetech.com>
---
 .../bindings/net/motorcomm,yt8xxx.yaml        | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)

Comments

Andrew Lunn July 20, 2023, 4 p.m. UTC | #1 
> +  motorcomm,rx-clk-drv-microamp:
> +    description: |
> +      drive strength of rx_clk rgmii pad.
> +      The YT8531 RGMII LDO voltage supports 1.8V/3.3V, and the LDO voltage can
> +      be configured with hardware pull-up resistors to match the SOC voltage
> +      (usually 1.8V).
> +      The software can read the registers to obtain the LDO voltage and configure
> +      the legal drive strength(curren).
> +      =====================================================
> +      | voltage |        curren Available (uA)            |

current has a t.

> +      =====================================================
> +      | voltage |        curren Available (uA)            |

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Conor Dooley July 21, 2023, 9:18 a.m. UTC | #2 
On Thu, Jul 20, 2023 at 06:00:15PM +0200, Andrew Lunn wrote:
> > +  motorcomm,rx-clk-drv-microamp:
> > +    description: |
> > +      drive strength of rx_clk rgmii pad.
> > +      The YT8531 RGMII LDO voltage supports 1.8V/3.3V, and the LDO voltage can
> > +      be configured with hardware pull-up resistors to match the SOC voltage
> > +      (usually 1.8V).
> > +      The software can read the registers to obtain the LDO voltage and configure
> > +      the legal drive strength(curren).
> > +      =====================================================
> > +      | voltage |        curren Available (uA)            |
> 
> current has a t.
> 
> > +      =====================================================
> > +      | voltage |        curren Available (uA)            |
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

With the fixup,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
index 157e3bbcaf6f..605be74f8556 100644
--- a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
+++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
@@ -52,6 +52,40 @@  properties:
       for a timer.
     type: boolean
 
+  motorcomm,rx-clk-drv-microamp:
+    description: |
+      drive strength of rx_clk rgmii pad.
+      The YT8531 RGMII LDO voltage supports 1.8V/3.3V, and the LDO voltage can
+      be configured with hardware pull-up resistors to match the SOC voltage
+      (usually 1.8V).
+      The software can read the registers to obtain the LDO voltage and configure
+      the legal drive strength(curren).
+      =====================================================
+      | voltage |        curren Available (uA)            |
+      |   1.8v  | 1200 2100 2700 2910 3110 3600 3970 4350 |
+      |   3.3v  | 3070 4080 4370 4680 5020 5450 5740 6140 |
+      =====================================================
+    enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970,
+            4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ]
+    default: 2910
+
+  motorcomm,rx-data-drv-microamp:
+    description: |
+      drive strength of rx_data/rx_ctl rgmii pad.
+      The YT8531 RGMII LDO voltage supports 1.8V/3.3V, and the LDO voltage can
+      be configured with hardware pull-up resistors to match the SOC voltage
+      (usually 1.8V).
+      The software can read the registers to obtain the LDO voltage and configure
+      the legal drive strength(curren).
+      =====================================================
+      | voltage |        curren Available (uA)            |
+      |   1.8v  | 1200 2100 2700 2910 3110 3600 3970 4350 |
+      |   3.3v  | 3070 4080 4370 4680 5020 5450 5740 6140 |
+      =====================================================
+    enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970,
+            4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ]
+    default: 2910
+
   motorcomm,tx-clk-adj-enabled:
     description: |
       This configuration is mainly to adapt to VF2 with JH7110 SoC.