| Message ID | 20230720190201.446469-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 75d42b351f564b2568392a4e53cd74a3d9df4af2 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | pull-request: bluetooth 2023-07-20 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Pull request for net |
| netdev/build_32bit | success | Errors and warnings before: 1369 this patch: 1368 |
| netdev/build_clang | success | Errors and warnings before: 1365 this patch: 1365 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | fail | Problems with Fixes tag: 1 |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1392 this patch: 1391 |
On Thu, 20 Jul 2023 12:02:00 -0700 Luiz Augusto von Dentz wrote: > bluetooth pull request for net: > > - Fix building with coredump disabled > - Fix use-after-free in hci_remove_adv_monitor > - Use RCU for hci_conn_params and iterate safely in hci_sync > - Fix locking issues on ISO and SCO > - Fix bluetooth on Intel Macbook 2014 One bad fixes tag here, but good enough. Hopefully the big RCU-ifying patch won't blow up :)
Hi Jakub, On Thu, Jul 20, 2023 at 2:25 PM Jakub Kicinski <kuba@kernel.org> wrote: > > On Thu, 20 Jul 2023 12:02:00 -0700 Luiz Augusto von Dentz wrote: > > bluetooth pull request for net: > > > > - Fix building with coredump disabled > > - Fix use-after-free in hci_remove_adv_monitor > > - Use RCU for hci_conn_params and iterate safely in hci_sync > > - Fix locking issues on ISO and SCO > > - Fix bluetooth on Intel Macbook 2014 > > One bad fixes tag here, but good enough. > Hopefully the big RCU-ifying patch won't blow up :) Weird, I'd run verify-fixes and it didn't show up anything. As for the RCU changes, yeah I was considering pulling it out but since it is a single commit with no other dependencies we can always just revert it if it causes problems.
Hello: This pull request was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 20 Jul 2023 12:02:00 -0700 you wrote: > The following changes since commit ac528649f7c63bc233cc0d33cff11f767cc666e3: > > Merge branch 'net-support-stp-on-bridge-in-non-root-netns' (2023-07-20 10:46:33 +0200) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2023-07-20 > > [...] Here is the summary with links: - pull-request: bluetooth 2023-07-20 https://git.kernel.org/netdev/net/c/75d42b351f56 You are awesome, thank you!
On Thu, 20 Jul 2023 14:30:02 -0700 Luiz Augusto von Dentz wrote: > > One bad fixes tag here, but good enough. > > Hopefully the big RCU-ifying patch won't blow up :) > > Weird, I'd run verify-fixes and it didn't show up anything. I think it works by checking the git database. If the commit exists in your git it will not complain. So you need a somewhat pristine repo instance to avoid false negatives.
The following changes since commit ac528649f7c63bc233cc0d33cff11f767cc666e3: Merge branch 'net-support-stp-on-bridge-in-non-root-netns' (2023-07-20 10:46:33 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2023-07-20 for you to fetch changes up to d1f0a9816f5fbc1316355ec1aa4ddfb9b624cca5: Bluetooth: MGMT: Use correct address for memcpy() (2023-07-20 11:27:22 -0700) ---------------------------------------------------------------- bluetooth pull request for net: - Fix building with coredump disabled - Fix use-after-free in hci_remove_adv_monitor - Use RCU for hci_conn_params and iterate safely in hci_sync - Fix locking issues on ISO and SCO - Fix bluetooth on Intel Macbook 2014 ---------------------------------------------------------------- Andy Shevchenko (1): Bluetooth: MGMT: Use correct address for memcpy() Arnd Bergmann (1): Bluetooth: coredump: fix building with coredump disabled Douglas Anderson (1): Bluetooth: hci_sync: Avoid use-after-free in dbg for hci_remove_adv_monitor() Pauli Virtanen (4): Bluetooth: use RCU for hci_conn_params and iterate safely in hci_sync Bluetooth: hci_event: call disconnect callback before deleting conn Bluetooth: ISO: fix iso_conn related locking and validity issues Bluetooth: SCO: fix sco_conn related locking and validity issues Siddh Raman Pant (1): Bluetooth: hci_conn: return ERR_PTR instead of NULL when there is no link Tomasz Moń (1): Bluetooth: btusb: Fix bluetooth on Intel Macbook 2014 drivers/bluetooth/btusb.c | 1 + include/net/bluetooth/hci_core.h | 7 ++- net/bluetooth/hci_conn.c | 14 ++--- net/bluetooth/hci_core.c | 42 +++++++++++--- net/bluetooth/hci_event.c | 15 +++-- net/bluetooth/hci_sync.c | 117 +++++++++++++++++++++++++++++++++++---- net/bluetooth/iso.c | 53 ++++++++++-------- net/bluetooth/mgmt.c | 28 ++++------ net/bluetooth/sco.c | 23 ++++---- 9 files changed, 217 insertions(+), 83 deletions(-)