| Message ID | 20230726092543.6362-1-jose.marchesi@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 10d78a66a5f29fbbde1b09b5139c17c436b08c6e |
| Delegated to: | BPF |
| Headers | show |
| Series | bpf, docs: fix BPF_NEG entry in instruction-set.rst | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
| bpf/vmtest-bpf-next-VM_Test-1 | success | Logs for ShellCheck |
| bpf/vmtest-bpf-next-VM_Test-6 | success | Logs for set-matrix |
| bpf/vmtest-bpf-next-VM_Test-2 | success | Logs for build for aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-4 | success | Logs for build for x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-5 | success | Logs for build for x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-3 | success | Logs for build for s390x with gcc |
| bpf/vmtest-bpf-next-VM_Test-7 | success | Logs for test_maps on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-9 | success | Logs for test_maps on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-11 | success | Logs for test_progs on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-15 | success | Logs for test_progs_no_alu32 on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-19 | success | Logs for test_progs_no_alu32_parallel on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-22 | success | Logs for test_progs_parallel on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-25 | success | Logs for test_verifier on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-29 | success | Logs for veristat |
| bpf/vmtest-bpf-next-VM_Test-10 | success | Logs for test_maps on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-13 | success | Logs for test_progs on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-14 | success | Logs for test_progs on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-17 | success | Logs for test_progs_no_alu32 on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-18 | success | Logs for test_progs_no_alu32 on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-20 | success | Logs for test_progs_no_alu32_parallel on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-21 | success | Logs for test_progs_no_alu32_parallel on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-23 | success | Logs for test_progs_parallel on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-24 | success | Logs for test_progs_parallel on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-27 | success | Logs for test_verifier on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-28 | success | Logs for test_verifier on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-26 | success | Logs for test_verifier on s390x with gcc |
| bpf/vmtest-bpf-next-VM_Test-12 | success | Logs for test_progs on s390x with gcc |
| bpf/vmtest-bpf-next-PR | success | PR summary |
| bpf/vmtest-bpf-next-VM_Test-8 | success | Logs for test_maps on s390x with gcc |
| bpf/vmtest-bpf-next-VM_Test-16 | success | Logs for test_progs_no_alu32 on s390x with gcc |
> -----Original Message----- > From: Jose E. Marchesi <jose.marchesi@oracle.com> > Sent: Wednesday, July 26, 2023 2:26 AM > To: bpf@vger.kernel.org > Subject: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst > > This patch fixes the documentation of the BPF_NEG instruction to denote > that it does not use the source register operand. > > Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com> > --- > Documentation/bpf/standardization/instruction-set.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/bpf/standardization/instruction-set.rst > b/Documentation/bpf/standardization/instruction-set.rst > index 751e657973f0..6ef5534b410a 100644 > --- a/Documentation/bpf/standardization/instruction-set.rst > +++ b/Documentation/bpf/standardization/instruction-set.rst > @@ -165,7 +165,7 @@ BPF_OR 0x40 dst \|= src > BPF_AND 0x50 dst &= src > BPF_LSH 0x60 dst <<= (src & mask) > BPF_RSH 0x70 dst >>= (src & mask) > -BPF_NEG 0x80 dst = -src > +BPF_NEG 0x80 dst = -dst > BPF_MOD 0x90 dst = (src != 0) ? (dst % src) : dst > BPF_XOR 0xa0 dst ^= src > BPF_MOV 0xb0 dst = src > -- > 2.30.2 Acked-by: Dave Thaler <dthaler@microsoft.com> Also, all changes to files in the standardization directory should also be cc'ed to bpf@ietf.org, which I am doing on this email. Dave
>> -----Original Message----- >> From: Jose E. Marchesi <jose.marchesi@oracle.com> >> Sent: Wednesday, July 26, 2023 2:26 AM >> To: bpf@vger.kernel.org >> Subject: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst >> >> This patch fixes the documentation of the BPF_NEG instruction to denote >> that it does not use the source register operand. >> >> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com> >> --- >> Documentation/bpf/standardization/instruction-set.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/bpf/standardization/instruction-set.rst >> b/Documentation/bpf/standardization/instruction-set.rst >> index 751e657973f0..6ef5534b410a 100644 >> --- a/Documentation/bpf/standardization/instruction-set.rst >> +++ b/Documentation/bpf/standardization/instruction-set.rst >> @@ -165,7 +165,7 @@ BPF_OR 0x40 dst \|= src >> BPF_AND 0x50 dst &= src >> BPF_LSH 0x60 dst <<= (src & mask) >> BPF_RSH 0x70 dst >>= (src & mask) >> -BPF_NEG 0x80 dst = -src >> +BPF_NEG 0x80 dst = -dst >> BPF_MOD 0x90 dst = (src != 0) ? (dst % src) : dst >> BPF_XOR 0xa0 dst ^= src >> BPF_MOV 0xb0 dst = src >> -- >> 2.30.2 > > Acked-by: Dave Thaler <dthaler@microsoft.com> > > Also, all changes to files in the standardization directory should also be cc'ed > to bpf@ietf.org, which I am doing on this email. Will do in future posts. Thanks for CCing. > Dave
On 7/26/23 2:25 AM, Jose E. Marchesi wrote: > This patch fixes the documentation of the BPF_NEG instruction to > denote that it does not use the source register operand. > > Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com> Acked-by: Yonghong Song <yonghong.song@linux.dev> > --- > Documentation/bpf/standardization/instruction-set.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst > index 751e657973f0..6ef5534b410a 100644 > --- a/Documentation/bpf/standardization/instruction-set.rst > +++ b/Documentation/bpf/standardization/instruction-set.rst > @@ -165,7 +165,7 @@ BPF_OR 0x40 dst \|= src > BPF_AND 0x50 dst &= src > BPF_LSH 0x60 dst <<= (src & mask) > BPF_RSH 0x70 dst >>= (src & mask) > -BPF_NEG 0x80 dst = -src > +BPF_NEG 0x80 dst = -dst > BPF_MOD 0x90 dst = (src != 0) ? (dst % src) : dst > BPF_XOR 0xa0 dst ^= src > BPF_MOV 0xb0 dst = src
Hello: This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <ast@kernel.org>: On Wed, 26 Jul 2023 11:25:43 +0200 you wrote: > This patch fixes the documentation of the BPF_NEG instruction to > denote that it does not use the source register operand. > > Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com> > --- > Documentation/bpf/standardization/instruction-set.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - bpf, docs: fix BPF_NEG entry in instruction-set.rst https://git.kernel.org/bpf/bpf-next/c/10d78a66a5f2 You are awesome, thank you!
diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst index 751e657973f0..6ef5534b410a 100644 --- a/Documentation/bpf/standardization/instruction-set.rst +++ b/Documentation/bpf/standardization/instruction-set.rst @@ -165,7 +165,7 @@ BPF_OR 0x40 dst \|= src BPF_AND 0x50 dst &= src BPF_LSH 0x60 dst <<= (src & mask) BPF_RSH 0x70 dst >>= (src & mask) -BPF_NEG 0x80 dst = -src +BPF_NEG 0x80 dst = -dst BPF_MOD 0x90 dst = (src != 0) ? (dst % src) : dst BPF_XOR 0xa0 dst ^= src BPF_MOV 0xb0 dst = src
This patch fixes the documentation of the BPF_NEG instruction to denote that it does not use the source register operand. Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com> --- Documentation/bpf/standardization/instruction-set.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)