| Message ID | 20230726163200.2138394-1-thierry.reding@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a0b1b2055be34c0ec1371764d040164cde1ead79 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: stmmac: tegra: Properly allocate clock bulk data | expand |
On Wed, Jul 26, 2023 at 06:32:00PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> + Revanth Kumar Uppala <ruppala@nvidia.com>, Bhadram Varka <vbhadram@nvidia.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com As per the output of ./scripts/get_maintainer.pl --git-min-percent 25 this.patch which is the preferred method to determine the CC list for Networking patches. > The clock data is an array of struct clk_bulk_data, so make sure to > allocate enough memory. > > Fixes: d8ca113724e7 ("net: stmmac: tegra: Add MGBE support") > Signed-off-by: Thierry Reding <treding@nvidia.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c > index 99e2e5a5cd60..78a492b91bc6 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c > @@ -234,7 +234,8 @@ static int tegra_mgbe_probe(struct platform_device *pdev) > res.addr = mgbe->regs; > res.irq = irq; > > - mgbe->clks = devm_kzalloc(&pdev->dev, sizeof(*mgbe->clks), GFP_KERNEL); > + mgbe->clks = devm_kcalloc(&pdev->dev, ARRAY_SIZE(mgbe_clks), > + sizeof(*mgbe->clks), GFP_KERNEL); > if (!mgbe->clks) > return -ENOMEM; > > -- > 2.41.0 > >
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Wed, 26 Jul 2023 18:32:00 +0200 you wrote: > From: Thierry Reding <treding@nvidia.com> > > The clock data is an array of struct clk_bulk_data, so make sure to > allocate enough memory. > > Fixes: d8ca113724e7 ("net: stmmac: tegra: Add MGBE support") > Signed-off-by: Thierry Reding <treding@nvidia.com> > > [...] Here is the summary with links: - net: stmmac: tegra: Properly allocate clock bulk data https://git.kernel.org/netdev/net/c/a0b1b2055be3 You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c index 99e2e5a5cd60..78a492b91bc6 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c @@ -234,7 +234,8 @@ static int tegra_mgbe_probe(struct platform_device *pdev) res.addr = mgbe->regs; res.irq = irq; - mgbe->clks = devm_kzalloc(&pdev->dev, sizeof(*mgbe->clks), GFP_KERNEL); + mgbe->clks = devm_kcalloc(&pdev->dev, ARRAY_SIZE(mgbe_clks), + sizeof(*mgbe->clks), GFP_KERNEL); if (!mgbe->clks) return -ENOMEM;