| Message ID | 20230727005741.114069-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 64a37272fa5fb2d951ebd1a96fd42b045d64924c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] team: Remove NULL check before dev_{put, hold} | expand |
On Thu, Jul 27, 2023 at 08:57:41AM +0800, Yang Li wrote: > The call netdev_{put, hold} of dev_{put, hold} will check NULL, > so there is no need to check before using dev_{put, hold}, > remove it to silence the warning: > > ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 27 Jul 2023 08:57:41 +0800 you wrote: > The call netdev_{put, hold} of dev_{put, hold} will check NULL, > so there is no need to check before using dev_{put, hold}, > remove it to silence the warning: > > ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > > [...] Here is the summary with links: - [net-next] team: Remove NULL check before dev_{put, hold} https://git.kernel.org/netdev/net-next/c/64a37272fa5f You are awesome, thank you!
On Thu, Jul 27, 2023 at 08:57:41AM +0800, Yang Li wrote: > The call netdev_{put, hold} of dev_{put, hold} will check NULL, > so there is no need to check before using dev_{put, hold}, > remove it to silence the warning: > > ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Acked-by: Hangbin Liu <liuhangbin@gmail.com> > --- > drivers/net/team/team.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c > index d3dc22509ea5..bc50fc3f6913 100644 > --- a/drivers/net/team/team.c > +++ b/drivers/net/team/team.c > @@ -2321,8 +2321,7 @@ static struct team *team_nl_team_get(struct genl_info *info) > ifindex = nla_get_u32(info->attrs[TEAM_ATTR_TEAM_IFINDEX]); > dev = dev_get_by_index(net, ifindex); > if (!dev || dev->netdev_ops != &team_netdev_ops) { > - if (dev) > - dev_put(dev); > + dev_put(dev); > return NULL; > } > > -- > 2.20.1.7.g153144c >
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index d3dc22509ea5..bc50fc3f6913 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -2321,8 +2321,7 @@ static struct team *team_nl_team_get(struct genl_info *info) ifindex = nla_get_u32(info->attrs[TEAM_ATTR_TEAM_IFINDEX]); dev = dev_get_by_index(net, ifindex); if (!dev || dev->netdev_ops != &team_netdev_ops) { - if (dev) - dev_put(dev); + dev_put(dev); return NULL; }
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning: ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/team/team.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)