From patchwork Fri Jul 28 18:39:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 13332576 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63CAF23B8 for ; Fri, 28 Jul 2023 18:40:21 +0000 (UTC) Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 967D14C1F for ; Fri, 28 Jul 2023 11:39:57 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6862842a028so1795367b3a.0 for ; Fri, 28 Jul 2023 11:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1690569596; x=1691174396; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=0b1iRSBKicUocO8cOaL7TfYCL5E1KaOYY4J67wcNFoc=; b=XuAbchiS8jK/DO6ffYmvS+zl8tl/UaqoECwz3rBZkQiJ5ybghjkQ7177qO8d43jGnA GW5+Q+BZ6nEi+yRWR+IKmDksqXREUsq3C0ehUFW8sdU/mV6l3F9ekkZzXX/z7PPWx/PR emXCb7AScQanbvWsfu8FVSe0mNaWGuplp/xUw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690569596; x=1691174396; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0b1iRSBKicUocO8cOaL7TfYCL5E1KaOYY4J67wcNFoc=; b=UEyyTytMshVV7mCX3MlY1oXFW/miebfoKu4QIr3Ki/hECNXoi829jzMqF44RVS9X/K NrrUO57mROlOmIpyd7bsDBRMogFyyE+OLvL643fb0QWHJJISAmqZR47k7R6ZFV/wi4t7 19hLVHHWqBhIelgLqXqIr+88UmjnXgwNLrX/vBgvzaGulEhwprKcdGgoB3baZ7AH4w6F rlNzm8OCa2OvU64blZFhEgLACzhbOmklyeFD0hUeBSdbvcqV4rDX3DLokFx4B6xUlvbV 4HmkS/O3KlmJAzh80LABDVd0P+PDkXw4bSxFB2nLL36pEsiGeGI+O5mk9eCLL2WtrJYd d2zA== X-Gm-Message-State: ABy/qLb3qNvv69RIFb6TvevPUoAy2y/9ymLRux2O4ovZyLYjruNOOINB NSB2ZIeO+snk7OGLqmxBpAVWSOc/Kk7xLzEpcGMPMbJHjTs4dX49MwSlkHhiMm2feizpDujn3TG D551et2X+e0wfghKkYUOGfhg12Cl5dJRCdY0VZR40K+iHairtcRnxCzTuwPxAMxupNr+DH6ZF9h baAlmRM+rrEQ== X-Google-Smtp-Source: APBJJlEP+5c2FcBEgQ0SFdmOIu8doINpWDSNhItYXWtzz4+78Z7f16MzEVYToX3CxhVXRU2wk15vdQ== X-Received: by 2002:a05:6a20:3d1e:b0:134:37bb:89be with SMTP id y30-20020a056a203d1e00b0013437bb89bemr2525901pzi.57.1690569596491; Fri, 28 Jul 2023 11:39:56 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id e3-20020aa78243000000b006866a293e58sm3589470pfn.176.2023.07.28.11.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 11:39:56 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , Doug Berger , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next] net: bcmgenet: Remove TX ring full logging Date: Fri, 28 Jul 2023 11:39:45 -0700 Message-Id: <20230728183945.760531-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MIME_NO_TEXT, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org There is no need to spam the kernel log with such an indication, remove this message. Signed-off-by: Florian Fainelli Reviewed-by: Simon Horman --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 2b5761ad2f92..24bade875ca6 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -2077,12 +2077,8 @@ static netdev_tx_t bcmgenet_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock(&ring->lock); if (ring->free_bds <= (nr_frags + 1)) { - if (!netif_tx_queue_stopped(txq)) { + if (!netif_tx_queue_stopped(txq)) netif_tx_stop_queue(txq); - netdev_err(dev, - "%s: tx ring %d full when queue %d awake\n", - __func__, index, ring->queue); - } ret = NETDEV_TX_BUSY; goto out; }