| Message ID | 20230731090535.21416-1-ruc_gongyuanjun@163.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0b6291ad1940c403734312d0e453e8dac9148f69 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,1/1] net: korina: handle clk prepare error in korina_probe() | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 31 Jul 2023 17:05:35 +0800 you wrote: > in korina_probe(), the return value of clk_prepare_enable() > should be checked since it might fail. we can use > devm_clk_get_optional_enabled() instead of devm_clk_get_optional() > and clk_prepare_enable() to automatically handle the error. > > Fixes: e4cd854ec487 ("net: korina: Get mdio input clock via common clock framework") > Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163.com> > > [...] Here is the summary with links: - [v2,1/1] net: korina: handle clk prepare error in korina_probe() https://git.kernel.org/netdev/net/c/0b6291ad1940 You are awesome, thank you!
diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 2b9335cb4bb3..8537578e1cf1 100644 --- a/drivers/net/ethernet/korina.c +++ b/drivers/net/ethernet/korina.c @@ -1302,11 +1302,10 @@ static int korina_probe(struct platform_device *pdev) else if (of_get_ethdev_address(pdev->dev.of_node, dev) < 0) eth_hw_addr_random(dev); - clk = devm_clk_get_optional(&pdev->dev, "mdioclk"); + clk = devm_clk_get_optional_enabled(&pdev->dev, "mdioclk"); if (IS_ERR(clk)) return PTR_ERR(clk); if (clk) { - clk_prepare_enable(clk); lp->mii_clock_freq = clk_get_rate(clk); } else { lp->mii_clock_freq = 200000000; /* max possible input clk */
in korina_probe(), the return value of clk_prepare_enable() should be checked since it might fail. we can use devm_clk_get_optional_enabled() instead of devm_clk_get_optional() and clk_prepare_enable() to automatically handle the error. Fixes: e4cd854ec487 ("net: korina: Get mdio input clock via common clock framework") Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163.com> --- drivers/net/ethernet/korina.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)