diff mbox series

[net-next] team: add __exit modifier to team_nl_fini()

Message ID 20230804113557.1699005-1-shaozhengchao@huawei.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series [net-next] team: add __exit modifier to team_nl_fini() | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1328 this patch: 1328
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 1351 this patch: 1351
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1351 this patch: 1351
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

shaozhengchao Aug. 4, 2023, 11:35 a.m. UTC 
team_nl_fini is only called when the module exits, so add the __exit
modifier to it.

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
 drivers/net/team/team.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman Aug. 5, 2023, 11:52 a.m. UTC | #1 
On Fri, Aug 04, 2023 at 07:35:57PM +0800, Zhengchao Shao wrote:
> team_nl_fini is only called when the module exits, so add the __exit
> modifier to it.
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>
Hangbin Liu Aug. 7, 2023, 2:38 a.m. UTC | #2 
On Fri, Aug 04, 2023 at 07:35:57PM +0800, Zhengchao Shao wrote:
> team_nl_fini is only called when the module exits, so add the __exit
> modifier to it.
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
>  drivers/net/team/team.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
> index bc50fc3f6913..e4fe70a71b40 100644
> --- a/drivers/net/team/team.c
> +++ b/drivers/net/team/team.c
> @@ -2892,7 +2892,7 @@ static int __init team_nl_init(void)
>  	return genl_register_family(&team_nl_family);
>  }
>  
> -static void team_nl_fini(void)
> +static void __exit team_nl_fini(void)
>  {
>  	genl_unregister_family(&team_nl_family);
>  }
> -- 
> 2.34.1

Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
diff mbox series

Patch

diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index bc50fc3f6913..e4fe70a71b40 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2892,7 +2892,7 @@  static int __init team_nl_init(void)
 	return genl_register_family(&team_nl_family);
 }
 
-static void team_nl_fini(void)
+static void __exit team_nl_fini(void)
 {
 	genl_unregister_family(&team_nl_family);
 }