diff mbox series

[net-next] devlink: clear flag on port register error path

Message ID 20230808082020.1363497-1-jiri@resnulli.us (mailing list archive)
State Accepted
Commit 832140804e3b3ad19d73adebd25f69ed98778c58
Delegated to: Netdev Maintainers
Headers show
Series [net-next] devlink: clear flag on port register error path | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1332 this patch: 1332
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 1353 this patch: 1353
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 1355 this patch: 1355
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 11 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Jiri Pirko Aug. 8, 2023, 8:20 a.m. UTC 
From: Jiri Pirko <jiri@nvidia.com>

When xarray insertion fails, clear the flag.

Fixes: 47b438cc2725 ("net: devlink: convert port_list into xarray")
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
 net/devlink/leftover.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Simon Horman Aug. 9, 2023, 2:27 p.m. UTC | #1 
On Tue, Aug 08, 2023 at 10:20:20AM +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> When xarray insertion fails, clear the flag.
> 
> Fixes: 47b438cc2725 ("net: devlink: convert port_list into xarray")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org Aug. 9, 2023, 8:10 p.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  8 Aug 2023 10:20:20 +0200 you wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> When xarray insertion fails, clear the flag.
> 
> Fixes: 47b438cc2725 ("net: devlink: convert port_list into xarray")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [net-next] devlink: clear flag on port register error path
    https://git.kernel.org/netdev/net-next/c/832140804e3b

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c
index 0a9b49dfeb61..5568992a1a90 100644
--- a/net/devlink/leftover.c
+++ b/net/devlink/leftover.c
@@ -6840,8 +6840,10 @@  int devl_port_register_with_ops(struct devlink *devlink,
 	spin_lock_init(&devlink_port->type_lock);
 	INIT_LIST_HEAD(&devlink_port->reporter_list);
 	err = xa_insert(&devlink->ports, port_index, devlink_port, GFP_KERNEL);
-	if (err)
+	if (err) {
+		devlink_port->registered = false;
 		return err;
+	}
 
 	INIT_DELAYED_WORK(&devlink_port->type_warn_dw, &devlink_port_type_warn);
 	devlink_port_type_warn_schedule(devlink_port);