| Message ID | 20230808114504.4036008-3-lizetao1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e62c7adfd4acc394c448870ba63d4315e7a662f6 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Remove redundant functions and use generic functions | expand |
> -----Original Message----- > From: Li Zetao <lizetao1@huawei.com> > Sent: Tuesday, August 8, 2023 5:15 PM > To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Linu Cherian > <lcherian@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>; > Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Hariprasad Kelam > <hkelam@marvell.com>; Subbaraya Sundeep Bhatta > <sbhatta@marvell.com>; davem@davemloft.net; edumazet@google.com; > kuba@kernel.org; pabeni@redhat.com > Cc: lizetao1@huawei.com; netdev@vger.kernel.org > Subject: [EXT] [PATCH net-next 2/3] octeontx2-af: Use u64_to_ether_addr() > to convert ethernet address > > External Email > > ---------------------------------------------------------------------- > Use u64_to_ether_addr() to convert a u64 value to an Ethernet MAC > address, instead of directly calculating, as this is exactly what this function > does. > > Signed-off-by: Li Zetao <lizetao1@huawei.com> > --- > drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c > index 095b2cc4a699..b3f766b970ca 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c > @@ -686,7 +686,7 @@ int rvu_mbox_handler_cgx_mac_addr_get(struct rvu > *rvu, { > int pf = rvu_get_pf(req->hdr.pcifunc); > u8 cgx_id, lmac_id; > - int rc = 0, i; > + int rc = 0; > u64 cfg; > > if (!is_cgx_config_permitted(rvu, req->hdr.pcifunc)) @@ -697,8 > +697,7 @@ int rvu_mbox_handler_cgx_mac_addr_get(struct rvu *rvu, > rsp->hdr.rc = rc; > cfg = cgx_lmac_addr_get(cgx_id, lmac_id); > /* copy 48 bit mac address to req->mac_addr */ > - for (i = 0; i < ETH_ALEN; i++) > - rsp->mac_addr[i] = cfg >> (ETH_ALEN - 1 - i) * 8; > + u64_to_ether_addr(cfg, rsp->mac_addr); > return 0; > } > > -- > 2.34.1 Ack.
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c index 095b2cc4a699..b3f766b970ca 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c @@ -686,7 +686,7 @@ int rvu_mbox_handler_cgx_mac_addr_get(struct rvu *rvu, { int pf = rvu_get_pf(req->hdr.pcifunc); u8 cgx_id, lmac_id; - int rc = 0, i; + int rc = 0; u64 cfg; if (!is_cgx_config_permitted(rvu, req->hdr.pcifunc)) @@ -697,8 +697,7 @@ int rvu_mbox_handler_cgx_mac_addr_get(struct rvu *rvu, rsp->hdr.rc = rc; cfg = cgx_lmac_addr_get(cgx_id, lmac_id); /* copy 48 bit mac address to req->mac_addr */ - for (i = 0; i < ETH_ALEN; i++) - rsp->mac_addr[i] = cfg >> (ETH_ALEN - 1 - i) * 8; + u64_to_ether_addr(cfg, rsp->mac_addr); return 0; }
Use u64_to_ether_addr() to convert a u64 value to an Ethernet MAC address, instead of directly calculating, as this is exactly what this function does. Signed-off-by: Li Zetao <lizetao1@huawei.com> --- drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)