| Message ID | 20230810103923.151226-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c5b0c34fae1ef234982d55445b8aa482f0b05ba6 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] net/xgene: fix Wvoid-pointer-to-enum-cast warning | expand |
On Thu, Aug 10, 2023 at 12:39:22PM +0200, Krzysztof Kozlowski wrote: > 'enet_id' is an enum, thus cast of pointer on 64-bit compile test with > W=1 causes: > > xgene_enet_main.c:2044:20: error: cast to smaller integer type 'enum xgene_enet_id' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Simon Horman <horms@kernel.org> # build-tested
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 10 Aug 2023 12:39:22 +0200 you wrote: > 'enet_id' is an enum, thus cast of pointer on 64-bit compile test with > W=1 causes: > > xgene_enet_main.c:2044:20: error: cast to smaller integer type 'enum xgene_enet_id' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > [...] Here is the summary with links: - [net-next,1/2] net/xgene: fix Wvoid-pointer-to-enum-cast warning https://git.kernel.org/netdev/net-next/c/c5b0c34fae1e - [net-next,2/2] net/marvell: fix Wvoid-pointer-to-enum-cast warning https://git.kernel.org/netdev/net-next/c/e5cd429e7928 You are awesome, thank you!
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 41d96f4b23d8..4d4140b7c450 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c @@ -2041,7 +2041,7 @@ static int xgene_enet_probe(struct platform_device *pdev) of_id = of_match_device(xgene_enet_of_match, &pdev->dev); if (of_id) { - pdata->enet_id = (enum xgene_enet_id)of_id->data; + pdata->enet_id = (uintptr_t)of_id->data; } #ifdef CONFIG_ACPI else {
'enet_id' is an enum, thus cast of pointer on 64-bit compile test with W=1 causes: xgene_enet_main.c:2044:20: error: cast to smaller integer type 'enum xgene_enet_id' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)