| Message ID | 20230812091708.34665-4-arinc.unal@arinc9.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Document internal MDIO bus of DSA switch and support it on MT7530 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 9 this patch: 9 |
| netdev/cc_maintainers | success | CCed 18 of 18 maintainers |
| netdev/build_clang | success | Errors and warnings before: 9 this patch: 9 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 9 this patch: 9 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
I will drop this patch because only the SMI controlled switches must define the compatible string. There's no way to make a distinction between the SMI and MDIO controlled switches on the schema so this would mean requiring the compatible property for the MDIO controlled switches too which is wrong. Arınç On 12.08.2023 12:17, Arınç ÜNAL wrote: > The compatible property must be defined under the mdio node. Enforce it. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > Documentation/devicetree/bindings/net/dsa/realtek.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml > index ea7db0890abc..f600e65fc990 100644 > --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml > @@ -103,6 +103,9 @@ allOf: > compatible: > const: realtek,smi-mdio > > + required: > + - compatible > + > - if: > required: > - reg
On Sat, Aug 12, 2023 at 12:17:07PM +0300, Arınç ÜNAL wrote: > The compatible property must be defined under the mdio node. Enforce it. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com> > Documentation/devicetree/bindings/net/dsa/realtek.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml > index ea7db0890abc..f600e65fc990 100644 > --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml > @@ -103,6 +103,9 @@ allOf: > compatible: > const: realtek,smi-mdio > > + required: > + - compatible > + > - if: > required: > - reg > -- > 2.39.2 >
On Sat, Aug 12, 2023 at 11:17 AM Arınç ÜNAL <arinc.unal@arinc9.com> wrote: > The compatible property must be defined under the mdio node. Enforce it. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> Right. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On 8/12/23 02:17, Arınç ÜNAL wrote: > The compatible property must be defined under the mdio node. Enforce it. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml index ea7db0890abc..f600e65fc990 100644 --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml @@ -103,6 +103,9 @@ allOf: compatible: const: realtek,smi-mdio + required: + - compatible + - if: required: - reg
The compatible property must be defined under the mdio node. Enforce it. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- Documentation/devicetree/bindings/net/dsa/realtek.yaml | 3 +++ 1 file changed, 3 insertions(+)