| Message ID | 20230817063006.10366-1-hkelam@marvell.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 05f3d5bc23524bed6f043dfe6b44da687584f9fb |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] octeontx2-af: SDP: fix receive link config | expand |
On Thu, Aug 17, 2023 at 12:00:06PM +0530, Hariprasad Kelam wrote: > On SDP interfaces, frame oversize and undersize errors are > observed as driver is not considering packet sizes of all > subscribers of the link before updating the link config. > > This patch fixes the same. > > Fixes: 9b7dd87ac071 ("octeontx2-af: Support to modify min/max allowed packet lengths") > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com> > Signed-off-by: Sunil Goutham <sgoutham@marvell.com> > --- > drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 17 Aug 2023 12:00:06 +0530 you wrote: > On SDP interfaces, frame oversize and undersize errors are > observed as driver is not considering packet sizes of all > subscribers of the link before updating the link config. > > This patch fixes the same. > > Fixes: 9b7dd87ac071 ("octeontx2-af: Support to modify min/max allowed packet lengths") > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com> > Signed-off-by: Sunil Goutham <sgoutham@marvell.com> > > [...] Here is the summary with links: - [net] octeontx2-af: SDP: fix receive link config https://git.kernel.org/netdev/net/c/05f3d5bc2352 You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c index 04b0e885f9d2..c2f68678e947 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c @@ -4270,9 +4270,10 @@ int rvu_mbox_handler_nix_set_hw_frs(struct rvu *rvu, struct nix_frs_cfg *req, if (link < 0) return NIX_AF_ERR_RX_LINK_INVALID; - nix_find_link_frs(rvu, req, pcifunc); linkcfg: + nix_find_link_frs(rvu, req, pcifunc); + cfg = rvu_read64(rvu, blkaddr, NIX_AF_RX_LINKX_CFG(link)); cfg = (cfg & ~(0xFFFFULL << 16)) | ((u64)req->maxlen << 16); if (req->update_minlen)
On SDP interfaces, frame oversize and undersize errors are observed as driver is not considering packet sizes of all subscribers of the link before updating the link config. This patch fixes the same. Fixes: 9b7dd87ac071 ("octeontx2-af: Support to modify min/max allowed packet lengths") Signed-off-by: Hariprasad Kelam <hkelam@marvell.com> Signed-off-by: Sunil Goutham <sgoutham@marvell.com> --- drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)