| Message ID | 20230818111401.77962-1-kurt@linutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 58f2ffdedf7b05b318f2cdafaca69e4435c8478e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] stmmac: intel: Enable correction of MAC propagation delay | expand |
On 8/18/23 13:14, Kurt Kanzenbach wrote: > All captured timestamps should be corrected by PHY, MAC and CDC introduced > latency/errors. The CDC correction is already used. Enable MAC propagation delay > correction as well which is available since commit 26cfb838aa00 ("net: stmmac: > correct MAC propagation delay"). > > Before: > |ptp4l[390.458]: rms 7 max 21 freq +177 +/- 14 delay 357 +/- 1 > > After: > |ptp4l[620.012]: rms 7 max 20 freq +195 +/- 14 delay 345 +/- 1 > > Tested on Intel Elkhart Lake. > > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> LGTM feel free to add my Reviewed-by: Johannes Zink <j.zink@pengutronix.de> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c > index 979c755964b1..a3a249c63598 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c > @@ -627,6 +627,7 @@ static int ehl_common_data(struct pci_dev *pdev, > plat->rx_queues_to_use = 8; > plat->tx_queues_to_use = 8; > plat->flags |= STMMAC_FLAG_USE_PHY_WOL; > + plat->flags |= STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY; > > plat->safety_feat_cfg->tsoee = 1; > plat->safety_feat_cfg->mrxpee = 1;
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 18 Aug 2023 13:14:01 +0200 you wrote: > All captured timestamps should be corrected by PHY, MAC and CDC introduced > latency/errors. The CDC correction is already used. Enable MAC propagation delay > correction as well which is available since commit 26cfb838aa00 ("net: stmmac: > correct MAC propagation delay"). > > Before: > |ptp4l[390.458]: rms 7 max 21 freq +177 +/- 14 delay 357 +/- 1 > > [...] Here is the summary with links: - [net-next] stmmac: intel: Enable correction of MAC propagation delay https://git.kernel.org/netdev/net-next/c/58f2ffdedf7b You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c index 979c755964b1..a3a249c63598 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c @@ -627,6 +627,7 @@ static int ehl_common_data(struct pci_dev *pdev, plat->rx_queues_to_use = 8; plat->tx_queues_to_use = 8; plat->flags |= STMMAC_FLAG_USE_PHY_WOL; + plat->flags |= STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY; plat->safety_feat_cfg->tsoee = 1; plat->safety_feat_cfg->mrxpee = 1;
All captured timestamps should be corrected by PHY, MAC and CDC introduced latency/errors. The CDC correction is already used. Enable MAC propagation delay correction as well which is available since commit 26cfb838aa00 ("net: stmmac: correct MAC propagation delay"). Before: |ptp4l[390.458]: rms 7 max 21 freq +177 +/- 14 delay 357 +/- 1 After: |ptp4l[620.012]: rms 7 max 20 freq +195 +/- 14 delay 345 +/- 1 Tested on Intel Elkhart Lake. Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 + 1 file changed, 1 insertion(+)