| Message ID | 20230822121916.23912-1-phil@nwl.cc (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute2] ss: Fix socket type check in packet_show_line() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
diff --git a/misc/ss.c b/misc/ss.c index de54b0da7a192..5156faf4dca7f 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -4534,9 +4534,9 @@ static int packet_show_line(char *buf, const struct filter *f, int fam) &type, &prot, &iface, &state, &rq, &uid, &ino); - if (stat.type == SOCK_RAW && !(f->dbs&(1<<PACKET_R_DB))) + if (type == SOCK_RAW && !(f->dbs&(1<<PACKET_R_DB))) return 0; - if (stat.type == SOCK_DGRAM && !(f->dbs&(1<<PACKET_DG_DB))) + if (type == SOCK_DGRAM && !(f->dbs&(1<<PACKET_DG_DB))) return 0; stat.type = type;
The field is accessed before being assigned a meaningful value, effectively disabling the checks. Fixes: 4a0053b606a34 ("ss: Unify packet stats output from netlink and proc") Signed-off-by: Phil Sutter <phil@nwl.cc> --- misc/ss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)