| Message ID | 20230831121914.660875-1-vinschen@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fa09bc40b21a33937872c4c4cf0f266ec9fa4869 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net] igb: disable virtualization features on 82580 | expand |
On Thu, Aug 31, 2023 at 02:19:13PM +0200, Corinna Vinschen wrote: > Disable virtualization features on 82580 just as on i210/i211. > This avoids that virt functions are acidentally called on 82850. > > Fixes: 55cac248caa4 ("igb: Add full support for 82580 devices") > Signed-off-by: Corinna Vinschen <vinschen@redhat.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 31 Aug 2023 14:19:13 +0200 you wrote: > Disable virtualization features on 82580 just as on i210/i211. > This avoids that virt functions are acidentally called on 82850. > > Fixes: 55cac248caa4 ("igb: Add full support for 82580 devices") > Signed-off-by: Corinna Vinschen <vinschen@redhat.com> > --- > drivers/net/ethernet/intel/igb/igb_main.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Here is the summary with links: - [v2,net] igb: disable virtualization features on 82580 https://git.kernel.org/netdev/net/c/fa09bc40b21a You are awesome, thank you!
On Sep 3 13:12, patchwork-bot+netdevbpf@kernel.org wrote: > Hello: > > This patch was applied to netdev/net.git (main) > by David S. Miller <davem@davemloft.net>: > > On Thu, 31 Aug 2023 14:19:13 +0200 you wrote: > > Disable virtualization features on 82580 just as on i210/i211. > > This avoids that virt functions are acidentally called on 82850. > > > > Fixes: 55cac248caa4 ("igb: Add full support for 82580 devices") > > Signed-off-by: Corinna Vinschen <vinschen@redhat.com> > > --- > > drivers/net/ethernet/intel/igb/igb_main.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > Here is the summary with links: > - [v2,net] igb: disable virtualization features on 82580 > https://git.kernel.org/netdev/net/c/fa09bc40b21a Thank you! Will my first patch igb: clean up in all error paths when enabling SR-IOV https://lore.kernel.org/netdev/20230824091603.3188249-1-vinschen@redhat.com/ get applied as well? While I reproduced this on 82580 only, there might be some other reason why pci_enable_sriov() fails, independent of the actual NIC. Thanks, Corinna
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 1ab787ed254d..13ba9c74bd84 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -3933,8 +3933,9 @@ static void igb_probe_vfs(struct igb_adapter *adapter) struct pci_dev *pdev = adapter->pdev; struct e1000_hw *hw = &adapter->hw; - /* Virtualization features not supported on i210 family. */ - if ((hw->mac.type == e1000_i210) || (hw->mac.type == e1000_i211)) + /* Virtualization features not supported on i210 and 82580 family. */ + if ((hw->mac.type == e1000_i210) || (hw->mac.type == e1000_i211) || + (hw->mac.type == e1000_82580)) return; /* Of the below we really only want the effect of getting
Disable virtualization features on 82580 just as on i210/i211. This avoids that virt functions are acidentally called on 82850. Fixes: 55cac248caa4 ("igb: Add full support for 82580 devices") Signed-off-by: Corinna Vinschen <vinschen@redhat.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)