| Message ID | 20230905231342.2042759-2-contact@jookia.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | can: sun4i_can: Only show Kconfig if ARCH_SUNXI is set | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Series ignored based on subject |
On Wed, Sep 6, 2023 at 1:15 AM John Watts <contact@jookia.org> wrote: > When adding the RISCV option I didn't gate it behind ARCH_SUNXI. > As a result this option shows up with Allwinner support isn't enabled. > Fix that by requiring ARCH_SUNXI to be set if RISCV is set. > > Fixes: 8abb95250ae6 ("can: sun4i_can: Add support for the Allwinner D1") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Closes: https://lore.kernel.org/linux-sunxi/CAMuHMdV2m54UAH0X2dG7stEg=grFihrdsz4+o7=_DpBMhjTbkw@mail.gmail.com/ > Signed-off-by: John Watts <contact@jookia.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi there, I'd like to bump this. Do I re-send this or just reply to it? John. On Wed, Sep 06, 2023 at 09:13:43AM +1000, John Watts wrote: > When adding the RISCV option I didn't gate it behind ARCH_SUNXI. > As a result this option shows up with Allwinner support isn't enabled. > Fix that by requiring ARCH_SUNXI to be set if RISCV is set. > > Fixes: 8abb95250ae6 ("can: sun4i_can: Add support for the Allwinner D1") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Closes: https://lore.kernel.org/linux-sunxi/CAMuHMdV2m54UAH0X2dG7stEg=grFihrdsz4+o7=_DpBMhjTbkw@mail.gmail.com/ > Signed-off-by: John Watts <contact@jookia.org> > --- > drivers/net/can/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig > index 649453a3c858..f8cde9f9f554 100644 > --- a/drivers/net/can/Kconfig > +++ b/drivers/net/can/Kconfig > @@ -190,7 +190,7 @@ config CAN_SLCAN > > config CAN_SUN4I > tristate "Allwinner A10 CAN controller" > - depends on MACH_SUN4I || MACH_SUN7I || RISCV || COMPILE_TEST > + depends on MACH_SUN4I || MACH_SUN7I || (RISCV && ARCH_SUNXI) || COMPILE_TEST > help > Say Y here if you want to use CAN controller found on Allwinner > A10/A20/D1 SoCs. > -- > 2.42.0 >
On 06.09.2023 09:13:43, John Watts wrote: > When adding the RISCV option I didn't gate it behind ARCH_SUNXI. > As a result this option shows up with Allwinner support isn't enabled. > Fix that by requiring ARCH_SUNXI to be set if RISCV is set. > > Fixes: 8abb95250ae6 ("can: sun4i_can: Add support for the Allwinner D1") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Closes: https://lore.kernel.org/linux-sunxi/CAMuHMdV2m54UAH0X2dG7stEg=grFihrdsz4+o7=_DpBMhjTbkw@mail.gmail.com/ > Signed-off-by: John Watts <contact@jookia.org> Applied to linux-can/testing. regards, Marc
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index 649453a3c858..f8cde9f9f554 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig @@ -190,7 +190,7 @@ config CAN_SLCAN config CAN_SUN4I tristate "Allwinner A10 CAN controller" - depends on MACH_SUN4I || MACH_SUN7I || RISCV || COMPILE_TEST + depends on MACH_SUN4I || MACH_SUN7I || (RISCV && ARCH_SUNXI) || COMPILE_TEST help Say Y here if you want to use CAN controller found on Allwinner A10/A20/D1 SoCs.
When adding the RISCV option I didn't gate it behind ARCH_SUNXI. As a result this option shows up with Allwinner support isn't enabled. Fix that by requiring ARCH_SUNXI to be set if RISCV is set. Fixes: 8abb95250ae6 ("can: sun4i_can: Add support for the Allwinner D1") Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Closes: https://lore.kernel.org/linux-sunxi/CAMuHMdV2m54UAH0X2dG7stEg=grFihrdsz4+o7=_DpBMhjTbkw@mail.gmail.com/ Signed-off-by: John Watts <contact@jookia.org> --- drivers/net/can/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)