diff mbox series

[2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles

Message ID 20230909123107.1048998-2-festevam@gmail.com (mailing list archive)
State Handled Elsewhere
Delegated to: Netdev Maintainers
Headers show
Series [1/2] dt-bindings: net: fec: Add imx8dxl description | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Fabio Estevam Sept. 9, 2023, 12:31 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. 

This fixes the following schema warning:

imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed:
	['fsl,imx8qm-fec'] is too short
	'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec']
	'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec']
	'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec']
	'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec']
	'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec']
	'fsl,imx8mq-fec' was expected
	'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec']
	'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec']
	'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec']
	from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paolo Abeni Sept. 12, 2023, 8:09 a.m. UTC | #1 
Hi,

On Sat, 2023-09-09 at 09:31 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. 
> 
> This fixes the following schema warning:
> 
> imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed:
> 	['fsl,imx8qm-fec'] is too short
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec']
> 	'fsl,imx8mq-fec' was expected
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec']
> 	from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

It looks like this series is targeting the net-next tree, am I
misreading this?

I guess we could have small conflicts whatever target tree we will use,
so I *think* the above should be ok. @Shawn Guo: do you prefer
otherwise?

Thanks,

Paolo
Paolo Abeni Sept. 14, 2023, 6:16 a.m. UTC | #2 
On Tue, 2023-09-12 at 10:09 +0200, Paolo Abeni wrote:
> Hi,
> 
> On Sat, 2023-09-09 at 09:31 -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> > 
> > Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. 
> > 
> > This fixes the following schema warning:
> > 
> > imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed:
> > 	['fsl,imx8qm-fec'] is too short
> > 	'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec']
> > 	'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec']
> > 	'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec']
> > 	'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec']
> > 	'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec']
> > 	'fsl,imx8mq-fec' was expected
> > 	'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec']
> > 	'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec']
> > 	'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec']
> > 	from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml#
> > 
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
> 
> It looks like this series is targeting the net-next tree, am I
> misreading this?
> 
> I guess we could have small conflicts whatever target tree we will use,
> so I *think* the above should be ok. @Shawn Guo: do you prefer
> otherwise?

Thinking again about it, I assume this should go via the devicetree git
tree, so I'm dropping it from the netdev pw.

Please correct me otherwise, thanks!

Paolo
Fabio Estevam Sept. 14, 2023, 10:27 a.m. UTC | #3 
Hi Paolo,

On 14/09/2023 03:16, Paolo Abeni wrote:

> Thinking again about it, I assume this should go via the devicetree git
> tree, so I'm dropping it from the netdev pw.

You're right. This one should go via Shawn's tree.

Thanks
Shawn Guo Sept. 25, 2023, 2:02 a.m. UTC | #4 
On Sat, Sep 09, 2023 at 09:31:07AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. 
> 
> This fixes the following schema warning:
> 
> imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed:
> 	['fsl,imx8qm-fec'] is too short
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec']
> 	'fsl,imx8mq-fec' was expected
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec']
> 	'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec']
> 	from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
index b47752a878c9..a414df645351 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
@@ -118,7 +118,7 @@  &enet0_lpcg {
 };
 
 &fec1 {
-	compatible = "fsl,imx8qm-fec";
+	compatible = "fsl,imx8dxl-fec", "fsl,imx8qm-fec", "fsl,imx6sx-fec";
 	interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
 		     <GIC_SPI 158 IRQ_TYPE_LEVEL_HIGH>,
 		     <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>,