diff mbox series

net: ti: icssg-prueth: add PTP dependency

Message ID 20230912185509.2430563-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit a8f367f7e131e76713b2949b168ac97f671fce7a
Delegated to: Netdev Maintainers
Headers show
Series net: ti: icssg-prueth: add PTP dependency | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 9 this patch: 9
netdev/cc_maintainers success CCed 12 of 12 maintainers
netdev/build_clang success Errors and warnings before: 9 this patch: 9
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 9 this patch: 9
netdev/checkpatch warning WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 186734c15886 ("net: ti: icssg-prueth: add packet timestamping and ptp support")'
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Arnd Bergmann Sept. 12, 2023, 6:54 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The driver can now use PTP if enabled but fails to link built-in
if PTP is a loadable module:

aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'

Add the usual dependency to avoid this.

Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

MD Danish Anwar Sept. 13, 2023, 6:24 a.m. UTC | #1 
On 13/09/23 00:24, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver can now use PTP if enabled but fails to link built-in
> if PTP is a loadable module:
> 
> aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
> icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'
> 
> Add the usual dependency to avoid this.
> 
> Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>

> ---
>  drivers/net/ethernet/ti/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index 7f3e2e96c6e20..26ddc26fc7b8d 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -201,6 +201,7 @@ config TI_ICSSG_PRUETH
>  
>  config TI_ICSS_IEP
>  	tristate "TI PRU ICSS IEP driver"
> +	depends on PTP_1588_CLOCK_OPTIONAL
>  	depends on TI_PRUSS
>  	default TI_PRUSS
>  	help
Jiri Pirko Sept. 13, 2023, 7:58 a.m. UTC | #2 
Tue, Sep 12, 2023 at 08:54:51PM CEST, arnd@kernel.org wrote:
>From: Arnd Bergmann <arnd@arndb.de>
>
>The driver can now use PTP if enabled but fails to link built-in
>if PTP is a loadable module:
>
>aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
>icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'
>
>Add the usual dependency to avoid this.
>
>Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>
patchwork-bot+netdevbpf@kernel.org Sept. 15, 2023, 9:40 a.m. UTC | #3 
Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Tue, 12 Sep 2023 20:54:51 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver can now use PTP if enabled but fails to link built-in
> if PTP is a loadable module:
> 
> aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
> icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'
> 
> [...]

Here is the summary with links:
  - net: ti: icssg-prueth: add PTP dependency
    https://git.kernel.org/netdev/net/c/a8f367f7e131

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 7f3e2e96c6e20..26ddc26fc7b8d 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -201,6 +201,7 @@  config TI_ICSSG_PRUETH
 
 config TI_ICSS_IEP
 	tristate "TI PRU ICSS IEP driver"
+	depends on PTP_1588_CLOCK_OPTIONAL
 	depends on TI_PRUSS
 	default TI_PRUSS
 	help