From patchwork Sat Sep 16 05:07:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13388126 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB3881FA3 for ; Sat, 16 Sep 2023 05:07:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8218A19AE; Fri, 15 Sep 2023 22:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=vCIxxdvf/dqUjZgY4hxlo2HkzPv50wadYLt6wlCZc9g=; b=ZiSeVCm5t5xoyb+HL4zuwKrIOy 0PkBGMWL/UFQtBrmvbLEigH+WgLa0v0WO/4ZIYfmhri3dpCNd+CWJ1E8VsAQfG+GFs0BezQm1lJYG DCvYIf16UMTB38nbnyOnXBQ6TZZYXs0kW6rfouTuROwBHyssvVNpqmC/zUNEYlgsOACk69oOhaIFL 3XSj64Nc8isU5I8TljRqPBKhWB5w53quULjNJcveZVQDviZcAHMADvNu53sxKMeE1ZdiTiHdENm6b MFcvVEKJzXsvD9pU85NYdmiGtF21GSyinSyT2ub7DlWqjSNhLcWAiFpPhIm9oFDiVzxGUrjPEUsld iz8R712g==; Received: from [2601:1c2:980:9ec0:e65e:37ff:febd:ee53] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qhNWK-00BxBO-1l; Sat, 16 Sep 2023 05:07:04 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Roger Quadros , Md Danish Anwar , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Subject: [PATCH] net: ti: icss-iep: add dependency for PTP Date: Fri, 15 Sep 2023 22:07:01 -0700 Message-ID: <20230916050701.15480-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org When CONFIG_PTP_1588_CLOCK=m and CONFIG_TI_ICSS_IEP=y, there are build errors when referencing PTP functions. Fix this by making TI_ICSS_IEP depend on PTP_1588_CLOCK_OPTIONAL. Also, since TI_ICSSG_PRUETH selects TI_ICSS_IEP and selects don't follow dependencies, make the former also depend on PTP_1588_CLOCK_OPTIONAL. Fixes these build errors: aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx': icss_iep.c:(.text+0x234): undefined reference to `ptp_clock_index' aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_exit': icss_iep.c:(.text+0x634): undefined reference to `ptp_clock_unregister' aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_init': icss_iep.c:(.text+0x1848): undefined reference to `ptp_clock_register' Fixes: c1e0230eeaab ("net: ti: icss-iep: Add IEP driver") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Closes: lore.kernel.org/r/202309151207.NPDMiINe-lkp@intel.com Cc: Roger Quadros Cc: Md Danish Anwar Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: netdev@vger.kernel.org Reviewed-by: Roger Quadros Reviewed-by: MD Danish Anwar --- drivers/net/ethernet/ti/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff -- a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig --- a/drivers/net/ethernet/ti/Kconfig +++ b/drivers/net/ethernet/ti/Kconfig @@ -189,6 +189,7 @@ config TI_ICSSG_PRUETH select TI_ICSS_IEP depends on PRU_REMOTEPROC depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER + depends on PTP_1588_CLOCK_OPTIONAL help Support dual Gigabit Ethernet ports over the ICSSG PRU Subsystem. This subsystem is available starting with the AM65 platform. @@ -200,6 +201,7 @@ config TI_ICSSG_PRUETH config TI_ICSS_IEP tristate "TI PRU ICSS IEP driver" depends on TI_PRUSS + depends on PTP_1588_CLOCK_OPTIONAL default TI_PRUSS help This driver enables support for the PRU-ICSS Industrial Ethernet