| Message ID | 20230921063501.1571222-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f77e9f13ba090d922fdd3f6e3485fc32010284db |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ethernet: xilinx: Drop kernel doc comment about return value | expand |
> -----Original Message----- > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Sent: Thursday, September 21, 2023 12:05 PM > To: David S . Miller <davem@davemloft.net> > Cc: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>; > netdev@vger.kernel.org; kernel@pengutronix.de; Eric Dumazet > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni > <pabeni@redhat.com> > Subject: [PATCH net-next] net: ethernet: xilinx: Drop kernel doc comment > about return value > > During review of the patch that became 2e0ec0afa902 ("net: ethernet: > xilinx: Convert to platform remove callback returning void") in > net-next, Radhey Shyam Pandey pointed out that the change makes the > documentation about the return value obsolete. The patch was applied > without addressing this feedback, so here comes a fix in a separate > patch. > > Fixes: 2e0ec0afa902 ("net: ethernet: xilinx: Convert to platform remove > callback returning void") > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> Thanks! > --- > Hello, > > I don't know if you keep net-next/main stable. If you're relaxed here, > feel free to squash this patch into the original commit. > > Best regards > Uwe > > drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c > b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > index 32a502e7318b..765aa516aada 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c > +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > @@ -1180,8 +1180,6 @@ static int xemaclite_of_probe(struct > platform_device *ofdev) > * This function is called if a device is physically removed from the system or > * if the driver module is being unloaded. It frees any resources allocated to > * the device. > - * > - * Return: 0, always. > */ > static void xemaclite_of_remove(struct platform_device *of_dev) > { > > base-commit: 940fcc189c51032dd0282cbee4497542c982ac59 > -- > 2.40.1
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 21 Sep 2023 08:35:01 +0200 you wrote: > During review of the patch that became 2e0ec0afa902 ("net: ethernet: > xilinx: Convert to platform remove callback returning void") in > net-next, Radhey Shyam Pandey pointed out that the change makes the > documentation about the return value obsolete. The patch was applied > without addressing this feedback, so here comes a fix in a separate > patch. > > [...] Here is the summary with links: - [net-next] net: ethernet: xilinx: Drop kernel doc comment about return value https://git.kernel.org/netdev/net-next/c/f77e9f13ba09 You are awesome, thank you!
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 32a502e7318b..765aa516aada 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -1180,8 +1180,6 @@ static int xemaclite_of_probe(struct platform_device *ofdev) * This function is called if a device is physically removed from the system or * if the driver module is being unloaded. It frees any resources allocated to * the device. - * - * Return: 0, always. */ static void xemaclite_of_remove(struct platform_device *of_dev) {
During review of the patch that became 2e0ec0afa902 ("net: ethernet: xilinx: Convert to platform remove callback returning void") in net-next, Radhey Shyam Pandey pointed out that the change makes the documentation about the return value obsolete. The patch was applied without addressing this feedback, so here comes a fix in a separate patch. Fixes: 2e0ec0afa902 ("net: ethernet: xilinx: Convert to platform remove callback returning void") Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, I don't know if you keep net-next/main stable. If you're relaxed here, feel free to squash this patch into the original commit. Best regards Uwe drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 -- 1 file changed, 2 deletions(-) base-commit: 940fcc189c51032dd0282cbee4497542c982ac59