diff mbox series

mac80211: fix station hash table max_size config dependency

Message ID 20230923032834.9694-1-roynatech@gmail.com (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series mac80211: fix station hash table max_size config dependency | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 9 this patch: 9
netdev/cc_maintainers success CCed 7 of 7 maintainers
netdev/build_clang success Errors and warnings before: 9 this patch: 9
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes fail Problems with Fixes tag: 1
netdev/build_allmodconfig_warn success Errors and warnings before: 9 this patch: 9
netdev/checkpatch warning WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: ebd82b39bf11 ("mac80211: make station hash table max_size configurable")'
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

roynatech@gmail.com Sept. 23, 2023, 3:28 a.m. UTC 
From: roynatech2544 <whiteshell2544@naver.com>

Commit ebd82b3 ("mac80211: make station hash table max_size configurable") introduced config
MAC80211_STA_HASH_MAX_SIZE, which is defined unconditionally even if MAC80211 is not set.
It doesn't look like it is dependent of MAC80211_DEBUG_MENU either, as its only user is sta_info.c
which is compiled unconditionally when MAC80211 != n. And without this config set somewhere, compile
would error out.

Make it depend on MAC80211 to correctly hide the config when MAC80211=n

Fixes: ebd82b3 ("mac80211: make station hash table max_size configurable")
Signed-off-by: roynatech2544 <whiteshell2544@naver.com>

Comments

Kalle Valo Sept. 26, 2023, 10:47 a.m. UTC | #1 
roynatech@gmail.com writes:

> From: roynatech2544 <whiteshell2544@naver.com>
>
> Commit ebd82b3 ("mac80211: make station hash table max_size configurable") introduced config
> MAC80211_STA_HASH_MAX_SIZE, which is defined unconditionally even if MAC80211 is not set.
> It doesn't look like it is dependent of MAC80211_DEBUG_MENU either, as its only user is sta_info.c
> which is compiled unconditionally when MAC80211 != n. And without this config set somewhere, compile
> would error out.
>
> Make it depend on MAC80211 to correctly hide the config when MAC80211=n
>
> Fixes: ebd82b3 ("mac80211: make station hash table max_size configurable")

The commit id in fixes tag is too short, more info in the wiki link
below.

> Signed-off-by: roynatech2544 <whiteshell2544@naver.com>

Please use your full legal name, no pseudonyms please. See wiki.
diff mbox series

Patch

diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 51ec8256b..b9dc520b6 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -296,7 +296,8 @@  config MAC80211_DEBUG_COUNTERS
 	  If unsure, say N.
 
 config MAC80211_STA_HASH_MAX_SIZE
-	int "Station hash table maximum size" if MAC80211_DEBUG_MENU
+	int "Station hash table maximum size"
+	depends on MAC80211
 	default 0
 	help
 	  Setting this option to a low value (e.g. 4) allows testing the