| Message ID | 20230926114943.16340-13-justinlai0215@realtek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add Realtek automotive PCIe driver | expand |
Hi Justin, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Justin-Lai/net-ethernet-realtek-rtase-Add-pci-table-supported-in-this-module/20230926-195218 base: net-next/main patch link: https://lore.kernel.org/r/20230926114943.16340-13-justinlai0215%40realtek.com patch subject: [PATCH net-next v8 12/13] net:ethernet:realtek: Update the Makefile and Kconfig in the realtek folder config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230927/202309270412.RCn7zweU-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230927/202309270412.RCn7zweU-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202309270412.RCn7zweU-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/net/ethernet/realtek/rtase/rtase_main.c:234:6: warning: no previous prototype for 'rtase_tx_clear' [-Wmissing-prototypes] 234 | void rtase_tx_clear(struct rtase_private *tp) | ^~~~~~~~~~~~~~ >> drivers/net/ethernet/realtek/rtase/rtase_main.c:636:6: warning: no previous prototype for 'rtase_rx_clear' [-Wmissing-prototypes] 636 | void rtase_rx_clear(struct rtase_private *tp) | ^~~~~~~~~~~~~~ >> drivers/net/ethernet/realtek/rtase/rtase_main.c:776:6: warning: no previous prototype for 'rtase_hw_set_rx_packet_filter' [-Wmissing-prototypes] 776 | void rtase_hw_set_rx_packet_filter(struct net_device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/realtek/rtase/rtase_main.c:879:6: warning: no previous prototype for 'rtase_hw_reset' [-Wmissing-prototypes] 879 | void rtase_hw_reset(const struct net_device *dev) | ^~~~~~~~~~~~~~ >> drivers/net/ethernet/realtek/rtase/rtase_main.c:1027:6: warning: no previous prototype for 'rtase_hw_start' [-Wmissing-prototypes] 1027 | void rtase_hw_start(const struct net_device *dev) | ^~~~~~~~~~~~~~ drivers/net/ethernet/realtek/rtase/rtase_main.c: In function 'rtase_open': >> drivers/net/ethernet/realtek/rtase/rtase_main.c:1140:25: warning: 'sprintf' argument 3 may overlap destination object 'dev' [-Wrestrict] 1140 | sprintf((char *)&ivec->name, "%s_int%i", dev->name, i); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/realtek/rtase/rtase_main.c:1105:42: note: destination object referenced by 'restrict'-qualified argument 1 was declared here 1105 | static int rtase_open(struct net_device *dev) | ~~~~~~~~~~~~~~~~~~~^~~ vim +/rtase_tx_clear +234 drivers/net/ethernet/realtek/rtase/rtase_main.c 9a15ffa44557f94 Justin Lai 2023-09-26 233 9a15ffa44557f94 Justin Lai 2023-09-26 @234 void rtase_tx_clear(struct rtase_private *tp) 9a15ffa44557f94 Justin Lai 2023-09-26 235 { 9a15ffa44557f94 Justin Lai 2023-09-26 236 struct rtase_ring *ring; 9a15ffa44557f94 Justin Lai 2023-09-26 237 u16 i; 9a15ffa44557f94 Justin Lai 2023-09-26 238 9a15ffa44557f94 Justin Lai 2023-09-26 239 for (i = 0; i < tp->func_tx_queue_num; i++) { 9a15ffa44557f94 Justin Lai 2023-09-26 240 ring = &tp->tx_ring[i]; 9a15ffa44557f94 Justin Lai 2023-09-26 241 rtase_tx_clear_range(ring, ring->dirty_idx, NUM_DESC); 9a15ffa44557f94 Justin Lai 2023-09-26 242 ring->cur_idx = 0; 9a15ffa44557f94 Justin Lai 2023-09-26 243 ring->dirty_idx = 0; 9a15ffa44557f94 Justin Lai 2023-09-26 244 } 9a15ffa44557f94 Justin Lai 2023-09-26 245 } 9a15ffa44557f94 Justin Lai 2023-09-26 246
diff --git a/drivers/net/ethernet/realtek/Kconfig b/drivers/net/ethernet/realtek/Kconfig index 93d9df55b361..57ef924deebd 100644 --- a/drivers/net/ethernet/realtek/Kconfig +++ b/drivers/net/ethernet/realtek/Kconfig @@ -113,4 +113,21 @@ config R8169 To compile this driver as a module, choose M here: the module will be called r8169. This is recommended. +config RTASE + tristate "Realtek Automotive Switch 9054/9068/9072/9075/9068/9071 PCIe Interface support" + depends on PCI + select CRC32 + help + Say Y here if you have a Realtek Ethernet adapter belonging to + the following families: + RTL9054 5GBit Ethernet + RTL9068 5GBit Ethernet + RTL9072 5GBit Ethernet + RTL9075 5GBit Ethernet + RTL9068 5GBit Ethernet + RTL9071 5GBit Ethernet + + To compile this driver as a module, choose M here: the module + will be called rtase. This is recommended. + endif # NET_VENDOR_REALTEK diff --git a/drivers/net/ethernet/realtek/Makefile b/drivers/net/ethernet/realtek/Makefile index 2e1d78b106b0..0c1c16f63e9a 100644 --- a/drivers/net/ethernet/realtek/Makefile +++ b/drivers/net/ethernet/realtek/Makefile @@ -8,3 +8,4 @@ obj-$(CONFIG_8139TOO) += 8139too.o obj-$(CONFIG_ATP) += atp.o r8169-objs += r8169_main.o r8169_firmware.o r8169_phy_config.o obj-$(CONFIG_R8169) += r8169.o +obj-$(CONFIG_RTASE) += rtase/
1. Add the RTASE entry in the Kconfig. 2. Add the CONFIG_RTASE entry in the Makefile. Signed-off-by: Justin Lai <justinlai0215@realtek.com> --- drivers/net/ethernet/realtek/Kconfig | 17 +++++++++++++++++ drivers/net/ethernet/realtek/Makefile | 1 + 2 files changed, 18 insertions(+)