| Message ID | 20230930023234.1903-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | hyperv: rndis_filter needs to select NLS | expand |
On Fri, Sep 29, 2023 at 07:32:34PM -0700, Randy Dunlap wrote: > rndis_filter uses utf8s_to_utf16s() which is provided by setting > NLS, so select NLS to fix the build error: > > ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined! > > Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Simon Horman <horms@kernel.org> # build-tested
From: Randy Dunlap <rdunlap@infradead.org> Sent: Friday, September 29, 2023 7:33 PM > Patches for this driver usually use the subject prefix "hv_netvsc: ", not "hyperv". Other than that minor tweak, Reviewed-by: Michael Kelley <mikelley@microsoft.com> > rndis_filter uses utf8s_to_utf16s() which is provided by setting > NLS, so select NLS to fix the build error: > > ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined! > > Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Haiyang Zhang <haiyangz@microsoft.com> > Cc: K. Y. Srinivasan <kys@microsoft.com> > Cc: Wei Liu <wei.liu@kernel.org> > Cc: Dexuan Cui <decui@microsoft.com> > Cc: linux-hyperv@vger.kernel.org > Cc: David S. Miller <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: netdev@vger.kernel.org > --- > drivers/net/hyperv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig > --- a/drivers/net/hyperv/Kconfig > +++ b/drivers/net/hyperv/Kconfig > @@ -3,5 +3,6 @@ config HYPERV_NET > tristate "Microsoft Hyper-V virtual network driver" > depends on HYPERV > select UCS2_STRING > + select NLS > help > Select this option to enable the Hyper-V virtual network driver.
diff -- a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig --- a/drivers/net/hyperv/Kconfig +++ b/drivers/net/hyperv/Kconfig @@ -3,5 +3,6 @@ config HYPERV_NET tristate "Microsoft Hyper-V virtual network driver" depends on HYPERV select UCS2_STRING + select NLS help Select this option to enable the Hyper-V virtual network driver.
rndis_filter uses utf8s_to_utf16s() which is provided by setting NLS, so select NLS to fix the build error: ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined! Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: K. Y. Srinivasan <kys@microsoft.com> Cc: Wei Liu <wei.liu@kernel.org> Cc: Dexuan Cui <decui@microsoft.com> Cc: linux-hyperv@vger.kernel.org Cc: David S. Miller <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: netdev@vger.kernel.org --- drivers/net/hyperv/Kconfig | 1 + 1 file changed, 1 insertion(+)