| Message ID | 20231010132113.3014691-2-idosch@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dbb13378ba306484214b84304e232723a2aaf10a |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: fib_tests: Fixes for multipath list receive tests | expand |
On 10/10/23 7:21 AM, Ido Schimmel wrote: > The test relies on the fib:fib_table_lookup trace point being triggered > once for each forwarded packet. If RP filter is not disabled, the trace > point will be triggered twice for each packet (for source validation and > forwarding), potentially masking actual bugs. Fix by explicitly > disabling RP filter. > > Before: > > # ./fib_tests.sh -t ipv4_mpath_list > > IPv4 multipath list receive tests > TEST: Multipath route hit ratio (1.99) [ OK ] > > After: > > # ./fib_tests.sh -t ipv4_mpath_list > > IPv4 multipath list receive tests > TEST: Multipath route hit ratio (.99) [ OK ] > > Fixes: 8ae9efb859c0 ("selftests: fib_tests: Add multipath list receive tests") > Reported-by: kernel test robot <oliver.sang@intel.com> > Closes: https://lore.kernel.org/netdev/202309191658.c00d8b8-oliver.sang@intel.com/ > Tested-by: kernel test robot <oliver.sang@intel.com> > Signed-off-by: Ido Schimmel <idosch@nvidia.com> > --- > tools/testing/selftests/net/fib_tests.sh | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: David Ahern <dsahern@kernel.org>
> -----Original Message----- > From: David Ahern <dsahern@kernel.org> > Sent: Tuesday, 10 October 2023 17:21 > To: Ido Schimmel <idosch@nvidia.com>; netdev@vger.kernel.org > Cc: davem@davemloft.net; kuba@kernel.org; pabeni@redhat.com; > edumazet@google.com; dsahern@gmail.com; Sriram Yagnaraman > <sriram.yagnaraman@est.tech>; oliver.sang@intel.com; mlxsw@nvidia.com > Subject: Re: [PATCH net 1/2] selftests: fib_tests: Disable RP filter in multipath > list receive test > > On 10/10/23 7:21 AM, Ido Schimmel wrote: > > The test relies on the fib:fib_table_lookup trace point being > > triggered once for each forwarded packet. If RP filter is not > > disabled, the trace point will be triggered twice for each packet (for > > source validation and forwarding), potentially masking actual bugs. > > Fix by explicitly disabling RP filter. > > > > Before: > > > > # ./fib_tests.sh -t ipv4_mpath_list > > > > IPv4 multipath list receive tests > > TEST: Multipath route hit ratio (1.99) [ OK ] > > > > After: > > > > # ./fib_tests.sh -t ipv4_mpath_list > > > > IPv4 multipath list receive tests > > TEST: Multipath route hit ratio (.99) [ OK ] > > > > Fixes: 8ae9efb859c0 ("selftests: fib_tests: Add multipath list receive > > tests") > > Reported-by: kernel test robot <oliver.sang@intel.com> > > Closes: > > https://lore.kernel.org/netdev/202309191658.c00d8b8-oliver.sang@intel. > > com/ > > Tested-by: kernel test robot <oliver.sang@intel.com> > > Signed-off-by: Ido Schimmel <idosch@nvidia.com> > > --- > > tools/testing/selftests/net/fib_tests.sh | 3 +++ > > 1 file changed, 3 insertions(+) > > > > Reviewed-by: David Ahern <dsahern@kernel.org> > Thanks a lot for fixing this Tested-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh index e7d2a530618a..0dbb26b4fa4a 100755 --- a/tools/testing/selftests/net/fib_tests.sh +++ b/tools/testing/selftests/net/fib_tests.sh @@ -2437,6 +2437,9 @@ ipv4_mpath_list_test() run_cmd "ip -n ns2 route add 203.0.113.0/24 nexthop via 172.16.201.2 nexthop via 172.16.202.2" run_cmd "ip netns exec ns2 sysctl -qw net.ipv4.fib_multipath_hash_policy=1" + run_cmd "ip netns exec ns2 sysctl -qw net.ipv4.conf.veth2.rp_filter=0" + run_cmd "ip netns exec ns2 sysctl -qw net.ipv4.conf.all.rp_filter=0" + run_cmd "ip netns exec ns2 sysctl -qw net.ipv4.conf.default.rp_filter=0" set +e local dmac=$(ip -n ns2 -j link show dev veth2 | jq -r '.[]["address"]')
The test relies on the fib:fib_table_lookup trace point being triggered once for each forwarded packet. If RP filter is not disabled, the trace point will be triggered twice for each packet (for source validation and forwarding), potentially masking actual bugs. Fix by explicitly disabling RP filter. Before: # ./fib_tests.sh -t ipv4_mpath_list IPv4 multipath list receive tests TEST: Multipath route hit ratio (1.99) [ OK ] After: # ./fib_tests.sh -t ipv4_mpath_list IPv4 multipath list receive tests TEST: Multipath route hit ratio (.99) [ OK ] Fixes: 8ae9efb859c0 ("selftests: fib_tests: Add multipath list receive tests") Reported-by: kernel test robot <oliver.sang@intel.com> Closes: https://lore.kernel.org/netdev/202309191658.c00d8b8-oliver.sang@intel.com/ Tested-by: kernel test robot <oliver.sang@intel.com> Signed-off-by: Ido Schimmel <idosch@nvidia.com> --- tools/testing/selftests/net/fib_tests.sh | 3 +++ 1 file changed, 3 insertions(+)