From patchwork Tue Oct 17 20:51:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 13426124 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4244343116 for ; Tue, 17 Oct 2023 20:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="hdqzzxLv" Received: from mail-vk1-xa36.google.com (mail-vk1-xa36.google.com [IPv6:2607:f8b0:4864:20::a36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF054BA for ; Tue, 17 Oct 2023 13:51:25 -0700 (PDT) Received: by mail-vk1-xa36.google.com with SMTP id 71dfb90a1353d-4a13374a1e8so2400353e0c.1 for ; Tue, 17 Oct 2023 13:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1697575884; x=1698180684; darn=vger.kernel.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=AwO/KdzP4teJUaTi2zOZwHSyt1Pxi98O9GvK84YlLuE=; b=hdqzzxLvwmm5pOmph3FuiCNKL334R7uPuYMV4Zs3gnaZ2MIBRcs0C7bWHhg23gFgO9 /PiwkxIds0/57eJ6j+igVgCLb5VLWRnr+MHV+K5Vo0bvuFkpYNsU1ZK9fTEL62JLKc4+ BiUgLlvTvKpSqXow1zUuORyDu874DxIsFDZN8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697575884; x=1698180684; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AwO/KdzP4teJUaTi2zOZwHSyt1Pxi98O9GvK84YlLuE=; b=OfHsG+6iurqryVGBEPCxEpr+DQyuphpdjGQuz2YuhyOY02Ha+90V0yrd4b+sDhCX6j pS9KEntDO71knOOoWQYoBjlaNIYzQSUFSLAb1AMH5rtoCrSQFT3HoaMiKAE105kvGFKo PSwyuCQpg4JmaZulTIqPN0u6EFJQSBAK5UaMcSnVNqGfmFJ4eBB/F5WKR/6hnhGC9aUZ Vp2YBbgAumwapSTzN2E1NOxPmG5NRDClGzr62L5fJ8CBKfBwDZFmbB8ab0yE3WcXgFH6 EdJ+yVhMpbAXrQG7BhAtln0390kAv3ij77vTK8VQ+zlUkrve1O8Vki6t9wmy/rFqZC5M djpw== X-Gm-Message-State: AOJu0Yyo6vmL8xAZ9POvBtUYJlG9JVPs1x/8EwW+BbvTDIMwurm63R1H HomYFFAounXMWXuheMxAHLwEHwi4kVjfuEt+jLcXOjTY8PMVZUShGLSBzN2uaqIZqODemvA/Dht 1Q3TPBTPH5rkkw8eqWPhPkR2CpxNshL2WY1oBjlpvaJ7vWBbVMDR/5C+oXbL8vk/sCBUBVaCsUf 2x65z0UKrs4g== X-Google-Smtp-Source: AGHT+IHRwLOjKtj3ub2aROY2oc6C9xE+2zatdB36kZmb4NjmjJI/IcInO7/uH0QsmGe+cVFlN3hJ4g== X-Received: by 2002:a05:6122:16a9:b0:4a8:4218:8074 with SMTP id 41-20020a05612216a900b004a842188074mr4346455vkl.8.1697575884473; Tue, 17 Oct 2023 13:51:24 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x20-20020ac87314000000b004194c21ee85sm893029qto.79.2023.10.17.13.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 13:51:23 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , Justin Chen , Andrew Lunn , Broadcom internal kernel review list , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Date: Tue, 17 Oct 2023 13:51:19 -0700 Message-Id: <20231017205119.416392-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MIME_NO_TEXT, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org The .probe() function would allocate the necessary space and ensure that the library call sizes the nunber of statistics but the callbacks necessary to fetch the name and values were not wired up. Reported-by: Justin Chen Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165") Reviewed-by: Andrew Lunn Signed-off-by: Florian Fainelli Reviewed-by: Simon Horman --- drivers/net/phy/bcm7xxx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c index 8478b081c058..97638ba7ae85 100644 --- a/drivers/net/phy/bcm7xxx.c +++ b/drivers/net/phy/bcm7xxx.c @@ -894,6 +894,9 @@ static int bcm7xxx_28nm_probe(struct phy_device *phydev) .name = _name, \ /* PHY_BASIC_FEATURES */ \ .flags = PHY_IS_INTERNAL, \ + .get_sset_count = bcm_phy_get_sset_count, \ + .get_strings = bcm_phy_get_strings, \ + .get_stats = bcm7xxx_28nm_get_phy_stats, \ .probe = bcm7xxx_28nm_probe, \ .config_init = bcm7xxx_16nm_ephy_config_init, \ .config_aneg = genphy_config_aneg, \