| Message ID | 20231020011856.3244410-6-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: deduplicate netdev name allocation | expand |
Fri, Oct 20, 2023 at 03:18:55AM CEST, kuba@kernel.org wrote: >__dev_alloc_name() is only called by dev_prep_valid_name(), >which already checks that name is valid. > >Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
diff --git a/net/core/dev.c b/net/core/dev.c index d2698b4bbad4..0830f2967221 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1077,9 +1077,6 @@ static int __dev_alloc_name(struct net *net, const char *name, char *res) struct net_device *d; char buf[IFNAMSIZ]; - if (!dev_valid_name(name)) - return -EINVAL; - /* Verify the string as this thing may have come from the user. * There must be one "%d" and no other "%" characters. */
__dev_alloc_name() is only called by dev_prep_valid_name(), which already checks that name is valid. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- net/core/dev.c | 3 --- 1 file changed, 3 deletions(-)