| Message ID | 20231020092758.211170-1-suhui@nfschina.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9f771493da935299c6393ad3563b581255d01a37 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: chelsio: cxgb4: add an error code check in t4_load_phy_fw | expand |
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 20 Oct 2023 17:27:59 +0800 you wrote: > t4_set_params_timeout() can return -EINVAL if failed, add check > for this. > > Signed-off-by: Su Hui <suhui@nfschina.com> > --- > drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2 ++ > 1 file changed, 2 insertions(+) Here is the summary with links: - net: chelsio: cxgb4: add an error code check in t4_load_phy_fw https://git.kernel.org/netdev/net/c/9f771493da93 You are awesome, thank you!
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index 8d719f82854a..76de55306c4d 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c @@ -3816,6 +3816,8 @@ int t4_load_phy_fw(struct adapter *adap, int win, FW_PARAMS_PARAM_Z_V(FW_PARAMS_PARAM_DEV_PHYFW_DOWNLOAD)); ret = t4_set_params_timeout(adap, adap->mbox, adap->pf, 0, 1, ¶m, &val, 30000); + if (ret) + return ret; /* If we have version number support, then check to see that the new * firmware got loaded properly.
t4_set_params_timeout() can return -EINVAL if failed, add check for this. Signed-off-by: Su Hui <suhui@nfschina.com> --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2 ++ 1 file changed, 2 insertions(+)