| Message ID | 20231020121853.3454896-1-Ilia.Gavrilov@infotecs.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 92fc97ae9cfd1e8c13d973ac92d224a185056840 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: atm: Remove redundant check. | expand |
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 20 Oct 2023 12:21:16 +0000 you wrote: > Checking the 'adev' variable is unnecessary, > because 'cdev' has already been checked earlier. > > Found by InfoTeCS on behalf of Linux Verification Center > (linuxtesting.org) with SVACE. > > Fixes: 656d98b09d57 ("[ATM]: basic sysfs support for ATM devices") > Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru> > > [...] Here is the summary with links: - [net-next] net: atm: Remove redundant check. https://git.kernel.org/netdev/net-next/c/92fc97ae9cfd You are awesome, thank you!
diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c index 466353b3dde4..54e7fb1a4ee5 100644 --- a/net/atm/atm_sysfs.c +++ b/net/atm/atm_sysfs.c @@ -116,8 +116,6 @@ static int atm_uevent(const struct device *cdev, struct kobj_uevent_env *env) return -ENODEV; adev = to_atm_dev(cdev); - if (!adev) - return -ENODEV; if (add_uevent_var(env, "NAME=%s%d", adev->type, adev->number)) return -ENOMEM;
Checking the 'adev' variable is unnecessary, because 'cdev' has already been checked earlier. Found by InfoTeCS on behalf of Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 656d98b09d57 ("[ATM]: basic sysfs support for ATM devices") Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru> --- net/atm/atm_sysfs.c | 2 -- 1 file changed, 2 deletions(-)