| Message ID | 20231103175551.41025-3-f.storniolo95@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bfada5a7672fea5465d81bba3d05fca6024a244e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | vsock: fix server prevents clients from reconnecting | expand |
On Fri, Nov 03, 2023 at 06:55:49PM +0100, f.storniolo95@gmail.com wrote: >From: Filippo Storniolo <f.storniolo95@gmail.com> > >Add check on socket() return value in vsock_listen() >and vsock_connect() > >Co-developed-by: Luigi Leonardi <luigi.leonardi@outlook.com> >Signed-off-by: Luigi Leonardi <luigi.leonardi@outlook.com> >Signed-off-by: Filippo Storniolo <f.storniolo95@gmail.com> >--- > tools/testing/vsock/util.c | 8 ++++++++ > 1 file changed, 8 insertions(+) If you need to resend the entire series, maybe you can remove "fix" from the commit title. But it's a minor thing, so I would only change it if there's something else that justifies sending a v2: Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > >diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c >index 92336721321a..698b0b44a2ee 100644 >--- a/tools/testing/vsock/util.c >+++ b/tools/testing/vsock/util.c >@@ -104,6 +104,10 @@ static int vsock_connect(unsigned int cid, unsigned int port, int type) > control_expectln("LISTENING"); > > fd = socket(AF_VSOCK, type, 0); >+ if (fd < 0) { >+ perror("socket"); >+ exit(EXIT_FAILURE); >+ } > > timeout_begin(TIMEOUT); > do { >@@ -158,6 +162,10 @@ static int vsock_accept(unsigned int cid, unsigned int port, > int old_errno; > > fd = socket(AF_VSOCK, type, 0); >+ if (fd < 0) { >+ perror("socket"); >+ exit(EXIT_FAILURE); >+ } > > if (bind(fd, &addr.sa, sizeof(addr.svm)) < 0) { > perror("bind"); >-- >2.41.0 >
diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c index 92336721321a..698b0b44a2ee 100644 --- a/tools/testing/vsock/util.c +++ b/tools/testing/vsock/util.c @@ -104,6 +104,10 @@ static int vsock_connect(unsigned int cid, unsigned int port, int type) control_expectln("LISTENING"); fd = socket(AF_VSOCK, type, 0); + if (fd < 0) { + perror("socket"); + exit(EXIT_FAILURE); + } timeout_begin(TIMEOUT); do { @@ -158,6 +162,10 @@ static int vsock_accept(unsigned int cid, unsigned int port, int old_errno; fd = socket(AF_VSOCK, type, 0); + if (fd < 0) { + perror("socket"); + exit(EXIT_FAILURE); + } if (bind(fd, &addr.sa, sizeof(addr.svm)) < 0) { perror("bind");