From patchwork Mon Nov 13 23:10:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Nguyen X-Patchwork-Id: 13454545 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3ECD3D38D for ; Mon, 13 Nov 2023 23:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RPCw2/wA" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C015D55 for ; Mon, 13 Nov 2023 15:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699917055; x=1731453055; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=S02doh2i4TL0Psx1T/iE7hQ/UyLpiMDl2/Zlo8lacGc=; b=RPCw2/wAiIY6vYYThBFvQG784YjolUtC4W12PH1fUgyPGZbWhCjTy5UH 3l8Bh80rPJdW7N+v76OaPKvNBrLsiFIIxT0Yu21vEVwOXBcsRNmrzeOVe OtV2LLXH9NPn1PT/jMLshWCGSvFSzV9iZRCcrx+8K4nkplVZakai9xdqz D4hCN49uclTW49nWmJ7H5TlQT510RtsXXoidHnL+BMLS/syjmupzQH2RR YvpdGwQllhge85gyX28Lq/NLobBlpoVEQjwBt0DXI18XYRj/aEFXy3ytC rCrUAEjCgYIxBee20x/HD3gNgIq3uLMAbLOpnJVaW/hkt/cAmGV+Qukm8 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="375562599" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="375562599" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2023 15:10:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="888051396" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="888051396" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by orsmga004.jf.intel.com with ESMTP; 13 Nov 2023 15:10:52 -0800 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org Cc: Su Hui , anthony.l.nguyen@intel.com, Dan Carpenter , Pucha Himasekhar Reddy Subject: [PATCH net-next 02/15] i40e: add an error code check in i40e_vsi_setup Date: Mon, 13 Nov 2023 15:10:21 -0800 Message-ID: <20231113231047.548659-3-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231113231047.548659-1-anthony.l.nguyen@intel.com> References: <20231113231047.548659-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Su Hui check the value of 'ret' after calling 'i40e_vsi_config_rss'. Signed-off-by: Su Hui Reviewed-by: Dan Carpenter Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index f7a332e51524..af8491f3211d 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -14591,9 +14591,13 @@ struct i40e_vsi *i40e_vsi_setup(struct i40e_pf *pf, u8 type, if ((pf->hw_features & I40E_HW_RSS_AQ_CAPABLE) && (vsi->type == I40E_VSI_VMDQ2)) { ret = i40e_vsi_config_rss(vsi); + if (ret) + goto err_config; } return vsi; +err_config: + i40e_vsi_clear_rings(vsi); err_rings: i40e_vsi_free_q_vectors(vsi); err_msix: