From patchwork Wed Nov 15 19:36:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 13457270 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8640F3C48F for ; Wed, 15 Nov 2023 19:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LpCpnWte" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E3A0C433CA; Wed, 15 Nov 2023 19:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700077023; bh=RJCHsO/j81Ch3TOk+80uDyM7v3CGIJRGarrYVT4QWXo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LpCpnWte0gGGfGlL7KZzeEgij0S4pR8lsZm14tAdIZl3WjMwUqpbNs2Cggk/0lYgX c9i2adqV8o8kq2HhjsCqcPR6o2/tWlIds1cGSABoWrRtrF9UaAV1RaH6oLX9aWPMmS Hcg7hRQPqSlXEZOXBP7ViQcI1+0yvI4bKx9oE/bRiU/3rXQWC0U0R26XqD/mWNBtlB De7BNtoM+QrOX8AAcv4KSPmkTfgBvpTUv0mopKfEYCD8tgnHYIbIfNPY7EUdDy1P8O V/DbVxnfxkjbARt5owJyMb0u2mJVkqWgA6TSw+yMvD3Z6mlyDavTajvU9d9ptDbeQq b8alIWjPhV0xA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Gal Pressman Subject: [net-next V2 13/13] net/mlx5e: Remove early assignment to netdev->features Date: Wed, 15 Nov 2023 11:36:49 -0800 Message-ID: <20231115193649.8756-14-saeed@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231115193649.8756-1-saeed@kernel.org> References: <20231115193649.8756-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Tariq Toukan The netdev->features is initialized to netdev->hw_features at a later point in the flow. Remove any redundant earlier assignment. Signed-off-by: Tariq Toukan Reviewed-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index ea58c6917433..3aecdf099a2f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -5244,7 +5244,6 @@ static void mlx5e_build_nic_netdev(struct net_device *netdev) netdev->gso_partial_features |= NETIF_F_GSO_UDP_L4; netdev->hw_features |= NETIF_F_GSO_UDP_L4; - netdev->features |= NETIF_F_GSO_UDP_L4; mlx5_query_port_fcs(mdev, &fcs_supported, &fcs_enabled);