| Message ID | 20231116-feature_poe-v1-5-be48044bf249@bootlin.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: Add support for Power over Ethernet (PoE) | expand |
On Thu, 16 Nov 2023 15:01:37 +0100 Kory Maincent wrote: > Remove podl from the attribute prefix to prepare the support of PoE pse > netlink spec. You need to run ./tools/net/ynl/ynl-regen.sh
On Sat, 18 Nov 2023 15:57:02 -0800 Jakub Kicinski <kuba@kernel.org> wrote: > On Thu, 16 Nov 2023 15:01:37 +0100 Kory Maincent wrote: > > Remove podl from the attribute prefix to prepare the support of PoE pse > > netlink spec. > > You need to run ./tools/net/ynl/ynl-regen.sh Ok, should I also send a patch with the newly generated files? Or is it something done by the maintainers? Regards,
On Mon, 20 Nov 2023 11:19:14 +0100 Köry Maincent wrote: > > You need to run ./tools/net/ynl/ynl-regen.sh > > Ok, should I also send a patch with the newly generated files? Or is it > something done by the maintainers? It needs to be part of the series. We don't have very clear guidelines on how to carry the regeneration. But for small changes like this you can squash the regenerated code into the spec change.
diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml index 5c7a65b009b4..e1bf75099264 100644 --- a/Documentation/netlink/specs/ethtool.yaml +++ b/Documentation/netlink/specs/ethtool.yaml @@ -878,17 +878,17 @@ attribute-sets: type: nest nested-attributes: header - - name: admin-state + name: podl-pse-admin-state type: u32 - name-prefix: ethtool-a-podl-pse- + name-prefix: ethtool-a- - - name: admin-control + name: podl-pse-admin-control type: u32 - name-prefix: ethtool-a-podl-pse- + name-prefix: ethtool-a- - - name: pw-d-status + name: podl-pse-pw-d-status type: u32 - name-prefix: ethtool-a-podl-pse- + name-prefix: ethtool-a- - name: rss attributes: @@ -1568,9 +1568,9 @@ operations: reply: attributes: &pse - header - - admin-state - - admin-control - - pw-d-status + - podl-pse-admin-state + - podl-pse-admin-control + - podl-pse-pw-d-status dump: *pse-get-op - name: pse-set
Remove podl from the attribute prefix to prepare the support of PoE pse netlink spec. Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> --- Documentation/netlink/specs/ethtool.yaml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)