| Message ID | 20231117171208.2066136-2-pctammela@mojatatu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 025de7b6a6dd44e78d0d45b4f3b4f104ed54b0fd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: tc-testing: more updates to tdc | expand |
On Fri, Nov 17, 2023 at 02:12:03PM -0300, Pedro Tammela wrote: > We have observed a lot of lock contention and test instability when running with >8 cores. > Enough to actually make the tests run slower than with fewer cores. > > Cap the maximum cores of parallel tdc to 4 which showed in testing to > be a reasonable number for efficiency and stability in different kernel > config scenarios. > > Signed-off-by: Pedro Tammela <pctammela@mojatatu.com> Hi Pedro, This limit seems a bit unfortunate, because it seems dependent on hardware and software details that are subject to change. Meanwhile this patch will be long since forgotten. But, OTOH, I can't think of a better idea at this time, so: Reviewed-by: Simon Horman <horms@kernel.org> ...
diff --git a/tools/testing/selftests/tc-testing/tdc.py b/tools/testing/selftests/tc-testing/tdc.py index a6718192aff3..f764b43f112b 100755 --- a/tools/testing/selftests/tc-testing/tdc.py +++ b/tools/testing/selftests/tc-testing/tdc.py @@ -1017,6 +1017,7 @@ def main(): parser = pm.call_add_args(parser) (args, remaining) = parser.parse_known_args() args.NAMES = NAMES + args.mp = min(args.mp, 4) pm.set_args(args) check_default_settings(args, remaining, pm) if args.verbose > 2:
We have observed a lot of lock contention and test instability when running with >8 cores. Enough to actually make the tests run slower than with fewer cores. Cap the maximum cores of parallel tdc to 4 which showed in testing to be a reasonable number for efficiency and stability in different kernel config scenarios. Signed-off-by: Pedro Tammela <pctammela@mojatatu.com> --- tools/testing/selftests/tc-testing/tdc.py | 1 + 1 file changed, 1 insertion(+)