| Message ID | 20231119141759.420477-1-chentao@kylinos.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c0e2926266af3b5acf28df0a8fc6e4d90effe0bb |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] ipv4: Correct/silence an endian warning in __ip_do_redirect | expand |
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Sun, 19 Nov 2023 22:17:59 +0800 you wrote: > net/ipv4/route.c:783:46: warning: incorrect type in argument 2 (different base types) > net/ipv4/route.c:783:46: expected unsigned int [usertype] key > net/ipv4/route.c:783:46: got restricted __be32 [usertype] new_gw > > Fixes: 969447f226b4 ("ipv4: use new_gw for redirect neigh lookup") > Suggested-by: Eric Dumazet <edumazet@google.com> > Signed-off-by: Kunwu Chan <chentao@kylinos.cn> > > [...] Here is the summary with links: - [v2] ipv4: Correct/silence an endian warning in __ip_do_redirect https://git.kernel.org/netdev/net/c/c0e2926266af You are awesome, thank you!
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 3290a4442b4a..16615d107cf0 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -780,7 +780,7 @@ static void __ip_do_redirect(struct rtable *rt, struct sk_buff *skb, struct flow goto reject_redirect; } - n = __ipv4_neigh_lookup(rt->dst.dev, new_gw); + n = __ipv4_neigh_lookup(rt->dst.dev, (__force u32)new_gw); if (!n) n = neigh_create(&arp_tbl, &new_gw, rt->dst.dev); if (!IS_ERR(n)) {
net/ipv4/route.c:783:46: warning: incorrect type in argument 2 (different base types) net/ipv4/route.c:783:46: expected unsigned int [usertype] key net/ipv4/route.c:783:46: got restricted __be32 [usertype] new_gw Fixes: 969447f226b4 ("ipv4: use new_gw for redirect neigh lookup") Suggested-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Kunwu Chan <chentao@kylinos.cn> --- net/ipv4/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)