| Message ID | 20231128160631.663351-5-pctammela@mojatatu.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/sched: optimizations around action binding and init | expand |
diff --git a/net/sched/act_api.c b/net/sched/act_api.c index 8517bfbd69a6..980dd3b51dd0 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -1290,12 +1290,10 @@ void tcf_idr_insert_many(struct tc_action *actions[], int init_res[]) { int i; - for (i = 0; i < TCA_ACT_MAX_PRIO; i++) { + for (i = 0; i < TCA_ACT_MAX_PRIO && actions[i]; i++) { struct tc_action *a = actions[i]; struct tcf_idrinfo *idrinfo; - if (!a) - continue; if (init_res[i] == 0) /* Bound */ continue;
The actions array is contiguous, so stop processing whenever a NULL is found. This is already the assumption for tcf_action_destroy[1], which is called from tcf_actions_init. [1] https://elixir.bootlin.com/linux/v6.7-rc3/source/net/sched/act_api.c#L1115 Signed-off-by: Pedro Tammela <pctammela@mojatatu.com> --- net/sched/act_api.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)