| Message ID | 20231128174813.394462-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 000db9e9ad42e135c7d92a56a66116542ae2b6c3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v1,1/1] net/sched: cbs: Use units.h instead of the copy of a definition | expand |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: > BYTES_PER_KBIT is defined in units.h, use that definition. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
On Tue, Nov 28, 2023 at 07:48:13PM +0200, Andy Shevchenko wrote: > BYTES_PER_KBIT is defined in units.h, use that definition. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks, this looks good to me. Reviewed-by: Simon Horman <horms@kernel.org> Did you consider a patch to update sja1105_main.c? It also seems to have a copy of BYTES_PER_KBIT.
On Thu, Nov 30, 2023 at 09:03:44PM +0000, Simon Horman wrote: > On Tue, Nov 28, 2023 at 07:48:13PM +0200, Andy Shevchenko wrote: > > BYTES_PER_KBIT is defined in units.h, use that definition. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Thanks, this looks good to me. > > Reviewed-by: Simon Horman <horms@kernel.org> > > Did you consider a patch to update sja1105_main.c? > It also seems to have a copy of BYTES_PER_KBIT. I now see that you did :)
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 28 Nov 2023 19:48:13 +0200 you wrote: > BYTES_PER_KBIT is defined in units.h, use that definition. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > net/sched/sch_cbs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [net-next,v1,1/1] net/sched: cbs: Use units.h instead of the copy of a definition https://git.kernel.org/netdev/net-next/c/000db9e9ad42 You are awesome, thank you!
diff --git a/net/sched/sch_cbs.c b/net/sched/sch_cbs.c index 9a0b85190a2c..beece8e82c23 100644 --- a/net/sched/sch_cbs.c +++ b/net/sched/sch_cbs.c @@ -57,6 +57,8 @@ #include <linux/string.h> #include <linux/errno.h> #include <linux/skbuff.h> +#include <linux/units.h> + #include <net/netevent.h> #include <net/netlink.h> #include <net/sch_generic.h> @@ -65,8 +67,6 @@ static LIST_HEAD(cbs_list); static DEFINE_SPINLOCK(cbs_list_lock); -#define BYTES_PER_KBIT (1000LL / 8) - struct cbs_sched_data { bool offload; int queue;
BYTES_PER_KBIT is defined in units.h, use that definition. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- net/sched/sch_cbs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)