From patchwork Tue Nov 28 23:21:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Lunn X-Patchwork-Id: 13471963 X-Patchwork-Delegate: kuba@kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="z8li9sxb" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 358601A3 for ; Tue, 28 Nov 2023 15:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:From:Sender:Reply-To:Subject:Date: Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Uv07crr7jfaQh41rhm4hZbyQzApuNQc5UJcqXiHaUIQ=; b=z8li9sxbphih/StjgY9LD3HjCz Nu7o6PlBExX81tp5WFg293iNuC/PycvLG+1DkhrvQ3IIZ2spr6WpdSLKBYfY0RA1DDC7EpCSOl2oI IG6Ht3o7vWzU2lnSBRaGEkRhOmtjJcVmlUWwf3yw9PiGsfeGOqwFiJEPFYJ4Q5qIZkPI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r87Op-001VJ0-Jq; Wed, 29 Nov 2023 00:21:51 +0100 From: Andrew Lunn To: netdev Cc: Linus Walleij , Christian Marangi , Vladimir Oltean , Florian Fainelli , Andrew Lunn Subject: [PATCH RFC net-next 3/8] net: dsa: Plumb LED brightnes and blink into switch API Date: Wed, 29 Nov 2023 00:21:30 +0100 Message-Id: <20231128232135.358638-4-andrew@lunn.ch> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20231128232135.358638-1-andrew@lunn.ch> References: <20231128232135.358638-1-andrew@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC Allow the switch driver to expose its methods to control the LED brightness and blinking to the DSA core. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 35 ++++++++++++++++++++++++++++++++ include/net/dsa.h | 8 ++++++++ 2 files changed, 43 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 6bd0a8e232a5..38b0d8259fa0 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -6803,6 +6803,39 @@ static int mv88e6xxx_crosschip_lag_leave(struct dsa_switch *ds, int sw_index, return err_sync ? : err_pvt; } +static int mv88e6xxx_led_brightness_set(struct dsa_switch *ds, int port, + u8 led, enum led_brightness value) +{ + struct mv88e6xxx_chip *chip = ds->priv; + int err; + + if (chip->info->ops->led_brightness_set) { + mv88e6xxx_reg_lock(chip); + err = chip->info->ops->led_brightness_set(chip, port, led, + value); + mv88e6xxx_reg_unlock(chip); + return err; + } + return -EOPNOTSUPP; +} + +static int mv88e6xxx_led_blink_set(struct dsa_switch *ds, int port, + u8 led, unsigned long *delay_on, + unsigned long *delay_off) +{ + struct mv88e6xxx_chip *chip = ds->priv; + int err; + + if (chip->info->ops->led_blink_set) { + mv88e6xxx_reg_lock(chip); + err = chip->info->ops->led_blink_set(chip, port, led, + delay_on, delay_off); + mv88e6xxx_reg_unlock(chip); + return err; + } + return -EOPNOTSUPP; +} + static const struct dsa_switch_ops mv88e6xxx_switch_ops = { .get_tag_protocol = mv88e6xxx_get_tag_protocol, .change_tag_protocol = mv88e6xxx_change_tag_protocol, @@ -6867,6 +6900,8 @@ static const struct dsa_switch_ops mv88e6xxx_switch_ops = { .crosschip_lag_change = mv88e6xxx_crosschip_lag_change, .crosschip_lag_join = mv88e6xxx_crosschip_lag_join, .crosschip_lag_leave = mv88e6xxx_crosschip_lag_leave, + .led_brightness_set = mv88e6xxx_led_brightness_set, + .led_blink_set = mv88e6xxx_led_blink_set, }; static int mv88e6xxx_register_switch(struct mv88e6xxx_chip *chip) diff --git a/include/net/dsa.h b/include/net/dsa.h index 82135fbdb1e6..ae73765cd71c 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -1238,6 +1238,14 @@ struct dsa_switch_ops { void (*conduit_state_change)(struct dsa_switch *ds, const struct net_device *conduit, bool operational); + + /* + * LED control + */ + int (*led_brightness_set)(struct dsa_switch *ds, int port, + u8 led, enum led_brightness value); + int (*led_blink_set)(struct dsa_switch *ds, int port, u8 led, + unsigned long *delay_on, unsigned long *delay_off); }; #define DSA_DEVLINK_PARAM_DRIVER(_id, _name, _type, _cmodes) \