| Message ID | 20231129021219.20914-11-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: at803x: cleanup + split | expand |
On Wed, Nov 29, 2023 at 03:12:15AM +0100, Christian Marangi wrote: > Drop useless probe for qca8081 PHY. The specific functions and the > generic ones doesn't use any of allocated variables of the at803x_priv > struct and doesn't support any of the properties used for at803x PHYs. So now we have two different structures in ->priv _and_ ->priv can be NULL all in the same driver. This is getting rediculous.
On Wed, Nov 29, 2023 at 09:44:42AM +0000, Russell King (Oracle) wrote: > On Wed, Nov 29, 2023 at 03:12:15AM +0100, Christian Marangi wrote: > > Drop useless probe for qca8081 PHY. The specific functions and the > > generic ones doesn't use any of allocated variables of the at803x_priv > > struct and doesn't support any of the properties used for at803x PHYs. > > So now we have two different structures in ->priv _and_ ->priv can be > NULL all in the same driver. > > This is getting rediculous. > Saddly this is the state of this PHY driver... Imagine me noticing that qca808x actually don't use any of the priv struct and doen't support any of the proprerty parsed in the OF function... Guess I have to move also this change where I split the driver. (again trying to keep change as little as possible)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 475b96165f45..32f44ef9835b 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -2387,7 +2387,6 @@ static struct phy_driver at803x_driver[] = { PHY_ID_MATCH_EXACT(QCA8081_PHY_ID), .name = "Qualcomm QCA8081", .flags = PHY_POLL_CABLE_TEST, - .probe = at803x_probe, .config_intr = at803x_config_intr, .handle_interrupt = at803x_handle_interrupt, .get_tunable = at803x_get_tunable,
Drop useless probe for qca8081 PHY. The specific functions and the generic ones doesn't use any of allocated variables of the at803x_priv struct and doesn't support any of the properties used for at803x PHYs. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- drivers/net/phy/at803x.c | 1 - 1 file changed, 1 deletion(-)