From patchwork Tue Dec 12 00:51:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 13488271 X-Patchwork-Delegate: kuba@kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="b/vjbFu5" Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D41BB8 for ; Mon, 11 Dec 2023 16:52:03 -0800 (PST) Received: by mail-qt1-x834.google.com with SMTP id d75a77b69052e-425952708afso35202771cf.0 for ; Mon, 11 Dec 2023 16:52:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1702342322; x=1702947122; darn=vger.kernel.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=A03aN42yKFJNYwriH9O+9ACFYNFi/+3xamR20lCO7dY=; b=b/vjbFu5wnP1ORM7H95U6vzssS3jMclBBEGVHwqA6aqqc/7XDnVBEO1CMSUwBJJQdH XuOCWD9yoock5ffTO9G7wR16rFsS+eFwiE888gP+LOALgxUe6AS5kATByj5lcN2mN5on yyug29x/0dtlMPasKs8HYPhzpwrZj4wWwBULc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702342322; x=1702947122; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A03aN42yKFJNYwriH9O+9ACFYNFi/+3xamR20lCO7dY=; b=iw9xukUeJMDOI1mcmAP0z/UZtdcT5KQvS3CD3LDmZIpe/O31j81qnTBiJH1+lx4FZf RQr7qGQtygeNzy1tUlVA10Veq7LjV1fpIsZvKvO7ri0lnK05rvBIDW2nVKCv5suWqYde xI3/4c5+LphHTLNvxtrfEScHAWgu4RkuWW5SuJF8ybX1rKzVzvJCScsJmSvhYMO00DpW 3dUxeFjShgWCS1St1ItBIsODOc4VdAutG4LcHRcniF7VmiZCcVID1I4ItGQS987xkmwy dqSHZyHQbJzPVOKfbFgim2dTyaoFKpDbhqUkD04G2rJ8d/BuBj/sbEo3vqE6TgBqnfxS g9Ew== X-Gm-Message-State: AOJu0YynTNJvN4nI9bpYoG3OotG3CWWx3KhxEh+n0lJfORLuH6FNnE48 xW/g0C1TQOPgxvxrJZaKN3qC5Q== X-Google-Smtp-Source: AGHT+IHkpwJzBtGVoOJaX4wvS0TUxxu9z0V6oXqRg3Sb7WV311XiFGP/nAL/nQfnlESZK2cw6bGZ/g== X-Received: by 2002:ac8:5dce:0:b0:425:4042:f45c with SMTP id e14-20020ac85dce000000b004254042f45cmr7615400qtx.64.1702342322504; Mon, 11 Dec 2023 16:52:02 -0800 (PST) Received: from lvnvda5233.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id r5-20020ac87945000000b00423ea1b31b3sm3619664qtt.66.2023.12.11.16.52.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2023 16:52:02 -0800 (PST) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, gospo@broadcom.com, Pavan Chebbi Subject: [PATCH net-next 13/13] bnxt_en: Make PTP TX timestamp HWRM query silent Date: Mon, 11 Dec 2023 16:51:22 -0800 Message-Id: <20231212005122.2401-14-michael.chan@broadcom.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20231212005122.2401-1-michael.chan@broadcom.com> References: <20231212005122.2401-1-michael.chan@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Pavan Chebbi In a busy network, especially with flow control enabled, we may experience timestamp query failures fairly regularly. After a while, dmesg may be flooded with timestamp query failure error messages. Silence the error message from the low level hwrm function that sends the firmware message. Change netdev_err() to netdev_WARN_ONCE() if this FW call ever fails. Signed-off-by: Pavan Chebbi Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c index 3d1c36d384c2..adad188e38b8 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c @@ -129,7 +129,7 @@ static int bnxt_hwrm_port_ts_query(struct bnxt *bp, u32 flags, u64 *ts) } resp = hwrm_req_hold(bp, req); - rc = hwrm_req_send(bp, req); + rc = hwrm_req_send_silent(bp, req); if (!rc) *ts = le64_to_cpu(resp->ptp_msg_ts); hwrm_req_drop(bp, req); @@ -684,8 +684,8 @@ static void bnxt_stamp_tx_skb(struct bnxt *bp, struct sk_buff *skb) timestamp.hwtstamp = ns_to_ktime(ns); skb_tstamp_tx(ptp->tx_skb, ×tamp); } else { - netdev_err(bp->dev, "TS query for TX timer failed rc = %x\n", - rc); + netdev_WARN_ONCE(bp->dev, + "TS query for TX timer failed rc = %x\n", rc); } dev_kfree_skb_any(ptp->tx_skb);