| Message ID | 20231215203353.635379-1-yury.norov@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 340943fbff3d8faa44d2223ca04917df28786a07 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: mana: select PAGE_POOL | expand |
On Fri, Dec 15, 2023 at 12:33:53PM -0800, Yury Norov wrote: > Mana uses PAGE_POOL API. x86_64 defconfig doesn't select it: > > ld: vmlinux.o: in function `mana_create_page_pool.isra.0': > mana_en.c:(.text+0x9ae36f): undefined reference to `page_pool_create' > ld: vmlinux.o: in function `mana_get_rxfrag': > mana_en.c:(.text+0x9afed1): undefined reference to `page_pool_alloc_pages' > make[3]: *** [/home/yury/work/linux/scripts/Makefile.vmlinux:37: vmlinux] Error 1 > make[2]: *** [/home/yury/work/linux/Makefile:1154: vmlinux] Error 2 > make[1]: *** [/home/yury/work/linux/Makefile:234: __sub-make] Error 2 > make[1]: Leaving directory '/home/yury/work/build-linux-x86_64' > make: *** [Makefile:234: __sub-make] Error 2 > > So we need to select it explicitly. > > Signed-off-by: Yury Norov <yury.norov@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Simon Horman <horms@kernel.org> # build-tested
On 12/15/23 23:33, Yury Norov wrote: > Mana uses PAGE_POOL API. x86_64 defconfig doesn't select it: > > ld: vmlinux.o: in function `mana_create_page_pool.isra.0': > mana_en.c:(.text+0x9ae36f): undefined reference to `page_pool_create' > ld: vmlinux.o: in function `mana_get_rxfrag': > mana_en.c:(.text+0x9afed1): undefined reference to `page_pool_alloc_pages' > make[3]: *** [/home/yury/work/linux/scripts/Makefile.vmlinux:37: vmlinux] Error 1 > make[2]: *** [/home/yury/work/linux/Makefile:1154: vmlinux] Error 2 > make[1]: *** [/home/yury/work/linux/Makefile:234: __sub-make] Error 2 > make[1]: Leaving directory '/home/yury/work/build-linux-x86_64' > make: *** [Makefile:234: __sub-make] Error 2 > > So we need to select it explicitly. > Fixes: ca9c54d2 ("net: mana: Add a driver for Microsoft Azure Network Adapter") > Signed-off-by: Yury Norov <yury.norov@gmail.com>
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Fri, 15 Dec 2023 12:33:53 -0800 you wrote: > Mana uses PAGE_POOL API. x86_64 defconfig doesn't select it: > > ld: vmlinux.o: in function `mana_create_page_pool.isra.0': > mana_en.c:(.text+0x9ae36f): undefined reference to `page_pool_create' > ld: vmlinux.o: in function `mana_get_rxfrag': > mana_en.c:(.text+0x9afed1): undefined reference to `page_pool_alloc_pages' > make[3]: *** [/home/yury/work/linux/scripts/Makefile.vmlinux:37: vmlinux] Error 1 > make[2]: *** [/home/yury/work/linux/Makefile:1154: vmlinux] Error 2 > make[1]: *** [/home/yury/work/linux/Makefile:234: __sub-make] Error 2 > make[1]: Leaving directory '/home/yury/work/build-linux-x86_64' > make: *** [Makefile:234: __sub-make] Error 2 > > [...] Here is the summary with links: - net: mana: select PAGE_POOL https://git.kernel.org/netdev/net/c/340943fbff3d You are awesome, thank you!
diff --git a/drivers/net/ethernet/microsoft/Kconfig b/drivers/net/ethernet/microsoft/Kconfig index 090e6b983243..01eb7445ead9 100644 --- a/drivers/net/ethernet/microsoft/Kconfig +++ b/drivers/net/ethernet/microsoft/Kconfig @@ -20,6 +20,7 @@ config MICROSOFT_MANA depends on PCI_MSI && X86_64 depends on PCI_HYPERV select AUXILIARY_BUS + select PAGE_POOL help This driver supports Microsoft Azure Network Adapter (MANA). So far, the driver is only supported on X86_64.
Mana uses PAGE_POOL API. x86_64 defconfig doesn't select it: ld: vmlinux.o: in function `mana_create_page_pool.isra.0': mana_en.c:(.text+0x9ae36f): undefined reference to `page_pool_create' ld: vmlinux.o: in function `mana_get_rxfrag': mana_en.c:(.text+0x9afed1): undefined reference to `page_pool_alloc_pages' make[3]: *** [/home/yury/work/linux/scripts/Makefile.vmlinux:37: vmlinux] Error 1 make[2]: *** [/home/yury/work/linux/Makefile:1154: vmlinux] Error 2 make[1]: *** [/home/yury/work/linux/Makefile:234: __sub-make] Error 2 make[1]: Leaving directory '/home/yury/work/build-linux-x86_64' make: *** [Makefile:234: __sub-make] Error 2 So we need to select it explicitly. Signed-off-by: Yury Norov <yury.norov@gmail.com> --- drivers/net/ethernet/microsoft/Kconfig | 1 + 1 file changed, 1 insertion(+)