| Message ID | 20231216194432.18963-2-ericwouds@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [RFC,net-next,1/2] Add en8811h bindings documentation yaml | expand |
On 16/12/2023 20:44, Eric Woudstra wrote: > The en8811h phy can be set with serdes polarity reversed on rx and/or tx. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. A nit, subject: drop second/last, redundant "bindings documentation yaml". The "dt-bindings" prefix is already stating that these are bindings. Quite redundant/useless subject. > > Signed-off-by: Eric Woudstra <ericwouds@gmail.com> > --- > .../bindings/net/airoha,en8811h.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml > > diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml > new file mode 100644 > index 000000000000..96febd8ed6fa > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Airoha EN8811H PHY > + > +maintainers: > + - Someone <someone@somemail.com> > + > +description: > + Bindings for Airoha EN8811H PHY Drop "Bindings for" and instead describe the hardware. Don't copy the title, what's the point in this? > + > +allOf: > + - $ref: ethernet-phy.yaml# > + > +properties: > + airoha,rx-pol-reverse: > + type: boolean > + description: > + Reverse rx polarity of SERDES. > + > + No, that won't work. Your schema is not being applied. Look at patches on the mailing list for the phys. Why do I see multiple patchsets of this? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml new file mode 100644 index 000000000000..96febd8ed6fa --- /dev/null +++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Airoha EN8811H PHY + +maintainers: + - Someone <someone@somemail.com> + +description: + Bindings for Airoha EN8811H PHY + +allOf: + - $ref: ethernet-phy.yaml# + +properties: + airoha,rx-pol-reverse: + type: boolean + description: + Reverse rx polarity of SERDES. + + + airoha,tx-pol-reverse: + type: boolean + description: + Reverse tx polarity of SERDES. + +unevaluatedProperties: false + +examples: + - | + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy1: ethernet-phy@1 { + reg = <1>; + airoha,rx-pol-reverse; + }; + };
The en8811h phy can be set with serdes polarity reversed on rx and/or tx. Signed-off-by: Eric Woudstra <ericwouds@gmail.com> --- .../bindings/net/airoha,en8811h.yaml | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml