| Message ID | 20231219210357.4029713-15-dw@davidwei.uk (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Zero copy Rx using io_uring | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply, async |
On Tue, Dec 19, 2023 at 1:04 PM David Wei <dw@davidwei.uk> wrote: > > From: Pavel Begunkov <asml.silence@gmail.com> > > Allow creating a special io_uring pp memory providers, which will be for > implementing io_uring zerocopy receive. > > Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> > Signed-off-by: David Wei <dw@davidwei.uk> For your non-RFC versions, I think maybe you want to do a patch by patch make W=1. I suspect this patch would build fail, because the next patch adds the io_uring_pp_zc_ops. You're likely skipping this step because this is an RFC, which is fine. > --- > include/net/page_pool/types.h | 1 + > net/core/page_pool.c | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h > index fd846cac9fb6..f54ee759e362 100644 > --- a/include/net/page_pool/types.h > +++ b/include/net/page_pool/types.h > @@ -129,6 +129,7 @@ struct mem_provider; > enum pp_memory_provider_type { > __PP_MP_NONE, /* Use system allocator directly */ > PP_MP_DMABUF_DEVMEM, /* dmabuf devmem provider */ > + PP_MP_IOU_ZCRX, /* io_uring zerocopy receive provider */ > }; > > struct pp_memory_provider_ops { > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 9e3073d61a97..ebf5ff009d9d 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -21,6 +21,7 @@ > #include <linux/ethtool.h> > #include <linux/netdevice.h> > #include <linux/genalloc.h> > +#include <linux/io_uring/net.h> > > #include <trace/events/page_pool.h> > > @@ -242,6 +243,11 @@ static int page_pool_init(struct page_pool *pool, > case PP_MP_DMABUF_DEVMEM: > pool->mp_ops = &dmabuf_devmem_ops; > break; > +#if defined(CONFIG_IO_URING) > + case PP_MP_IOU_ZCRX: > + pool->mp_ops = &io_uring_pp_zc_ops; > + break; > +#endif > default: > err = -EINVAL; > goto free_ptr_ring; > -- > 2.39.3 > -- Thanks, Mina
On 12/19/23 23:39, Mina Almasry wrote: > On Tue, Dec 19, 2023 at 1:04 PM David Wei <dw@davidwei.uk> wrote: >> >> From: Pavel Begunkov <asml.silence@gmail.com> >> >> Allow creating a special io_uring pp memory providers, which will be for >> implementing io_uring zerocopy receive. >> >> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> >> Signed-off-by: David Wei <dw@davidwei.uk> > > For your non-RFC versions, I think maybe you want to do a patch by > patch make W=1. I suspect this patch would build fail, because the > next patch adds the io_uring_pp_zc_ops. You're likely skipping this > step because this is an RFC, which is fine. Hmm? io_uring_pp_zc_ops is added is Patch 13, used in Patch 14. Compiles well. >> --- >> include/net/page_pool/types.h | 1 + >> net/core/page_pool.c | 6 ++++++ >> 2 files changed, 7 insertions(+) >> >> diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h >> index fd846cac9fb6..f54ee759e362 100644 >> --- a/include/net/page_pool/types.h >> +++ b/include/net/page_pool/types.h >> @@ -129,6 +129,7 @@ struct mem_provider; >> enum pp_memory_provider_type { >> __PP_MP_NONE, /* Use system allocator directly */ >> PP_MP_DMABUF_DEVMEM, /* dmabuf devmem provider */ >> + PP_MP_IOU_ZCRX, /* io_uring zerocopy receive provider */ >> }; >> >> struct pp_memory_provider_ops { >> diff --git a/net/core/page_pool.c b/net/core/page_pool.c >> index 9e3073d61a97..ebf5ff009d9d 100644 >> --- a/net/core/page_pool.c >> +++ b/net/core/page_pool.c >> @@ -21,6 +21,7 @@ >> #include <linux/ethtool.h> >> #include <linux/netdevice.h> >> #include <linux/genalloc.h> >> +#include <linux/io_uring/net.h> >> >> #include <trace/events/page_pool.h> >> >> @@ -242,6 +243,11 @@ static int page_pool_init(struct page_pool *pool, >> case PP_MP_DMABUF_DEVMEM: >> pool->mp_ops = &dmabuf_devmem_ops; >> break; >> +#if defined(CONFIG_IO_URING) >> + case PP_MP_IOU_ZCRX: >> + pool->mp_ops = &io_uring_pp_zc_ops; >> + break; >> +#endif >> default: >> err = -EINVAL; >> goto free_ptr_ring; >> -- >> 2.39.3 >> > > > -- > Thanks, > Mina
diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h index fd846cac9fb6..f54ee759e362 100644 --- a/include/net/page_pool/types.h +++ b/include/net/page_pool/types.h @@ -129,6 +129,7 @@ struct mem_provider; enum pp_memory_provider_type { __PP_MP_NONE, /* Use system allocator directly */ PP_MP_DMABUF_DEVMEM, /* dmabuf devmem provider */ + PP_MP_IOU_ZCRX, /* io_uring zerocopy receive provider */ }; struct pp_memory_provider_ops { diff --git a/net/core/page_pool.c b/net/core/page_pool.c index 9e3073d61a97..ebf5ff009d9d 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -21,6 +21,7 @@ #include <linux/ethtool.h> #include <linux/netdevice.h> #include <linux/genalloc.h> +#include <linux/io_uring/net.h> #include <trace/events/page_pool.h> @@ -242,6 +243,11 @@ static int page_pool_init(struct page_pool *pool, case PP_MP_DMABUF_DEVMEM: pool->mp_ops = &dmabuf_devmem_ops; break; +#if defined(CONFIG_IO_URING) + case PP_MP_IOU_ZCRX: + pool->mp_ops = &io_uring_pp_zc_ops; + break; +#endif default: err = -EINVAL; goto free_ptr_ring;