| Message ID | 20231220081914.16779-1-maimon.sagi@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 97417cd79ce179a774b245a3f5535cc3fbbaee50 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v1] ptp: ocp: fix bug in unregistering the DPLL subsystem | expand |
Wed, Dec 20, 2023 at 09:19:14AM CET, maimon.sagi@gmail.com wrote: >When unregistering the DPLL subsystem the priv pointer is different then >the one used for registration which cause failure in unregistering. > >Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops") Reviewed-by: Jiri Pirko <jiri@nvidia.com>
On 20/12/2023 08:19, Sagi Maimon wrote: > When unregistering the DPLL subsystem the priv pointer is different then > the one used for registration which cause failure in unregistering. > > Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops") > --- > drivers/ptp/ptp_ocp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c > index 4021d3d325f9..e7defce8cf48 100644 > --- a/drivers/ptp/ptp_ocp.c > +++ b/drivers/ptp/ptp_ocp.c > @@ -4492,7 +4492,7 @@ ptp_ocp_remove(struct pci_dev *pdev) > cancel_delayed_work_sync(&bp->sync_work); > for (i = 0; i < OCP_SMA_NUM; i++) { > if (bp->sma[i].dpll_pin) { > - dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, bp); > + dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, &bp->sma[i]); > dpll_pin_put(bp->sma[i].dpll_pin); > } > } Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Wed, 20 Dec 2023 10:19:14 +0200 you wrote: > When unregistering the DPLL subsystem the priv pointer is different then > the one used for registration which cause failure in unregistering. > > Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops") > --- > drivers/ptp/ptp_ocp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [v1] ptp: ocp: fix bug in unregistering the DPLL subsystem https://git.kernel.org/netdev/net/c/97417cd79ce1 You are awesome, thank you!
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index 4021d3d325f9..e7defce8cf48 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -4492,7 +4492,7 @@ ptp_ocp_remove(struct pci_dev *pdev) cancel_delayed_work_sync(&bp->sync_work); for (i = 0; i < OCP_SMA_NUM; i++) { if (bp->sma[i].dpll_pin) { - dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, bp); + dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, &bp->sma[i]); dpll_pin_put(bp->sma[i].dpll_pin); } }
When unregistering the DPLL subsystem the priv pointer is different then the one used for registration which cause failure in unregistering. Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops") --- drivers/ptp/ptp_ocp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)