| Message ID | 20240104140037.374166-4-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7a898539391dccce00c3cb24d96a6ba80cef7f6d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ds->user_mii_bus cleanup (part 1) | expand |
On Thu, Jan 04, 2024 at 04:00:30PM +0200, Vladimir Oltean wrote: > If the "lantiq,xrx200-mdio" child has status = "disabled", the MDIO bus > creation should be avoided. Use of_device_is_available() to check for > that, and take advantage of 2 facts: > > - of_device_is_available(NULL) returns false > - of_node_put(NULL) is a no-op > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk> > --- > drivers/net/dsa/lantiq_gswip.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)
On 1/4/24 06:00, Vladimir Oltean wrote: > If the "lantiq,xrx200-mdio" child has status = "disabled", the MDIO bus > creation should be avoided. Use of_device_is_available() to check for > that, and take advantage of 2 facts: > > - of_device_is_available(NULL) returns false > - of_node_put(NULL) is a no-op > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c index a514e6c78c38..de48b194048f 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -510,11 +510,11 @@ static int gswip_mdio(struct gswip_priv *priv) struct device_node *mdio_np, *switch_np = priv->dev->of_node; struct device *dev = priv->dev; struct mii_bus *bus; - int err; + int err = 0; mdio_np = of_get_compatible_child(switch_np, "lantiq,xrx200-mdio"); - if (!mdio_np) - return 0; + if (!of_device_is_available(mdio_np)) + goto out_put_node; bus = devm_mdiobus_alloc(dev); if (!bus) {
If the "lantiq,xrx200-mdio" child has status = "disabled", the MDIO bus creation should be avoided. Use of_device_is_available() to check for that, and take advantage of 2 facts: - of_device_is_available(NULL) returns false - of_node_put(NULL) is a no-op Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- drivers/net/dsa/lantiq_gswip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)