| Message ID | 20240105235439.28282-2-michael.chan@broadcom.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1ef4cacaae2f907db79faea4110ef90545467b7c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | bnxt_en: ntuple filter fixes | expand |
On Fri, Jan 05, 2024 at 03:54:37PM -0800, Michael Chan wrote: > After recent refactoring, this function doesn't return error any > more. Remove the unneeded rc variable and change the function to > void. The caller is not checking for the return value. > > Fixes: 96c9bedc755e ("bnxt_en: Refactor L2 filter alloc/free firmware commands.") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202401041942.qrB1amZM-lkp@intel.com/ > Signed-off-by: Michael Chan <michael.chan@broadcom.com> Hi Michael, I'm not sure this is a bug fix, so I might have cited the commit using something like "Introduced by commit ..." rather than a Fixes tag. But the fix isn't going to propagate very far anyway, as the cited commit is currently only in net-next. So perhaps it is fine as is. In any case, I agree that this is a nice update to the code. Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index b70ddd33e9ed..fb5af8a34c8f 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -5752,10 +5752,9 @@ static int bnxt_hwrm_set_vnic_filter(struct bnxt *bp, u16 vnic_id, u16 idx, return rc; } -static int bnxt_hwrm_clear_vnic_filter(struct bnxt *bp) +static void bnxt_hwrm_clear_vnic_filter(struct bnxt *bp) { u16 i, j, num_of_vnics = 1; /* only vnic 0 supported */ - int rc = 0; /* Any associated ntuple filters will also be cleared by firmware. */ for (i = 0; i < num_of_vnics; i++) { @@ -5769,8 +5768,6 @@ static int bnxt_hwrm_clear_vnic_filter(struct bnxt *bp) } vnic->uc_filter_count = 0; } - - return rc; } #define BNXT_DFLT_TUNL_TPA_BMAP \
After recent refactoring, this function doesn't return error any more. Remove the unneeded rc variable and change the function to void. The caller is not checking for the return value. Fixes: 96c9bedc755e ("bnxt_en: Refactor L2 filter alloc/free firmware commands.") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401041942.qrB1amZM-lkp@intel.com/ Signed-off-by: Michael Chan <michael.chan@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)